Skip to content

Support $this->assertIsString #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amalricBzh opened this issue Mar 31, 2020 · 2 comments
Closed

Support $this->assertIsString #67

amalricBzh opened this issue Mar 31, 2020 · 2 comments

Comments

@amalricBzh
Copy link

Hi,

I have this code :

$content = $client->getResponse()->getContent();
$this->assertIsString($content);
$this->assertJson($content);

phpstan throws an error:

Parameter #1 $actualJson of method PHPUnit\Framework\Assert::assertJson() expects string, string|false given.

I expect that phpstan understand that if assertIsString($content) passed, $content is a string, and phpstan should not throw an error.

My composer file:

"require-dev": {
    "phpstan/phpstan": "^0.11",
    "phpstan/phpstan-phpunit": "^0.11",
    [...]
}
@ondrejmirtes
Copy link
Member

Hi, upgrade to ^0.12, assertIsString is supported there.

You shouldn't have any problems upgrading to the latest versions. If you don't have time to fix newly reported errors now, you can take advantage of a feature called the baseline: https://medium.com/@ondrejmirtes/phpstans-baseline-feature-lets-you-hold-new-code-to-a-higher-standard-e77d815a5dff

@github-actions
Copy link

github-actions bot commented May 1, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants