-
Notifications
You must be signed in to change notification settings - Fork 506
/
Copy pathClassPropertiesNode.php
415 lines (372 loc) · 12.7 KB
/
ClassPropertiesNode.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
<?php declare(strict_types = 1);
namespace PHPStan\Node;
use PhpParser\Node;
use PhpParser\Node\Expr\Array_;
use PhpParser\Node\Expr\PropertyFetch;
use PhpParser\Node\Identifier;
use PhpParser\Node\Name;
use PhpParser\Node\Stmt\Class_;
use PhpParser\Node\Stmt\ClassLike;
use PhpParser\NodeAbstract;
use PHPStan\Analyser\Scope;
use PHPStan\Node\Expr\PropertyInitializationExpr;
use PHPStan\Node\Method\MethodCall;
use PHPStan\Node\Property\PropertyAssign;
use PHPStan\Node\Property\PropertyRead;
use PHPStan\Node\Property\PropertyWrite;
use PHPStan\Reflection\ClassReflection;
use PHPStan\Reflection\MethodReflection;
use PHPStan\Rules\Properties\ReadWritePropertiesExtensionProvider;
use PHPStan\TrinaryLogic;
use PHPStan\Type\NeverType;
use PHPStan\Type\TypeUtils;
use function array_diff_key;
use function array_key_exists;
use function array_keys;
use function in_array;
use function strtolower;
/**
* @api
*/
final class ClassPropertiesNode extends NodeAbstract implements VirtualNode
{
/**
* @param ClassPropertyNode[] $properties
* @param array<int, PropertyRead|PropertyWrite> $propertyUsages
* @param array<int, MethodCall> $methodCalls
* @param array<string, MethodReturnStatementsNode> $returnStatementNodes
* @param list<PropertyAssign> $propertyAssigns
*/
public function __construct(
private ClassLike $class,
private ReadWritePropertiesExtensionProvider $readWritePropertiesExtensionProvider,
private array $properties,
private array $propertyUsages,
private array $methodCalls,
private array $returnStatementNodes,
private array $propertyAssigns,
private ClassReflection $classReflection,
)
{
parent::__construct($class->getAttributes());
}
public function getClass(): ClassLike
{
return $this->class;
}
/**
* @return ClassPropertyNode[]
*/
public function getProperties(): array
{
return $this->properties;
}
/**
* @return array<int, PropertyRead|PropertyWrite>
*/
public function getPropertyUsages(): array
{
return $this->propertyUsages;
}
public function getType(): string
{
return 'PHPStan_Node_ClassPropertiesNode';
}
/**
* @return string[]
*/
public function getSubNodeNames(): array
{
return [];
}
public function getClassReflection(): ClassReflection
{
return $this->classReflection;
}
/**
* @param string[] $constructors
* @return array{array<string, ClassPropertyNode>, array<array{string, int, ClassPropertyNode, string, string}>, array<array{string, int, ClassPropertyNode}>}
*/
public function getUninitializedProperties(
Scope $scope,
array $constructors,
): array
{
if (!$this->getClass() instanceof Class_) {
return [[], [], []];
}
$classReflection = $this->getClassReflection();
$uninitializedProperties = [];
$originalProperties = [];
$initialInitializedProperties = [];
$initializedProperties = [];
$extensions = $this->readWritePropertiesExtensionProvider->getExtensions();
$initializedViaExtension = [];
foreach ($this->getProperties() as $property) {
if ($property->isStatic()) {
continue;
}
if ($property->isAbstract()) {
continue;
}
if ($property->getNativeType() === null) {
continue;
}
if ($property->getDefault() !== null) {
continue;
}
$originalProperties[$property->getName()] = $property;
$is = TrinaryLogic::createFromBoolean($property->isPromoted() && !$property->isPromotedFromTrait());
if (!$is->yes() && $classReflection->hasNativeProperty($property->getName())) {
$propertyReflection = $classReflection->getNativeProperty($property->getName());
if ($propertyReflection->isVirtual()->yes()) {
continue;
}
foreach ($extensions as $extension) {
if (!$extension->isInitialized($propertyReflection, $property->getName())) {
continue;
}
$is = TrinaryLogic::createYes();
$initializedViaExtension[$property->getName()] = true;
break;
}
}
$initialInitializedProperties[$property->getName()] = $is;
foreach ($constructors as $constructor) {
$initializedProperties[$constructor][$property->getName()] = $is;
}
if ($is->yes()) {
continue;
}
$uninitializedProperties[$property->getName()] = $property;
}
if ($constructors === []) {
return [$uninitializedProperties, [], []];
}
$initializedInConstructor = [];
if ($classReflection->hasConstructor()) {
$initializedInConstructor = array_diff_key($uninitializedProperties, $this->collectUninitializedProperties([$classReflection->getConstructor()->getName()], $uninitializedProperties));
}
$methodsCalledFromConstructor = $this->getMethodsCalledFromConstructor($classReflection, $initialInitializedProperties, $initializedProperties, $constructors, $initializedInConstructor);
$prematureAccess = [];
$additionalAssigns = [];
foreach ($this->getPropertyUsages() as $usage) {
$fetch = $usage->getFetch();
if (!$fetch instanceof PropertyFetch) {
continue;
}
$usageScope = $usage->getScope();
if ($usageScope->getFunction() === null) {
continue;
}
$function = $usageScope->getFunction();
if (!$function instanceof MethodReflection) {
continue;
}
if ($function->getDeclaringClass()->getName() !== $classReflection->getName()) {
continue;
}
if (!array_key_exists($function->getName(), $methodsCalledFromConstructor)) {
continue;
}
$initializedPropertiesMap = $methodsCalledFromConstructor[$function->getName()];
if (!$fetch->name instanceof Identifier) {
continue;
}
$propertyName = $fetch->name->toString();
$fetchedOnType = $usageScope->getType($fetch->var);
if (TypeUtils::findThisType($fetchedOnType) === null) {
continue;
}
$propertyReflection = $usageScope->getInstancePropertyReflection($fetchedOnType, $propertyName);
if ($propertyReflection === null) {
continue;
}
if ($propertyReflection->getDeclaringClass()->getName() !== $classReflection->getName()) {
continue;
}
if ($usage instanceof PropertyWrite) {
if (array_key_exists($propertyName, $initializedPropertiesMap)) {
$hasInitialization = $initializedPropertiesMap[$propertyName]->or($usageScope->hasExpressionType(new PropertyInitializationExpr($propertyName)));
if (
!$hasInitialization->no()
&& !$usage->isPromotedPropertyWrite()
&& !array_key_exists($propertyName, $initializedViaExtension)
) {
$additionalAssigns[] = [
$propertyName,
$fetch->getStartLine(),
$originalProperties[$propertyName],
];
}
}
} elseif (array_key_exists($propertyName, $initializedPropertiesMap)) {
if (
strtolower($function->getName()) !== '__construct'
&& array_key_exists($propertyName, $initializedInConstructor)
&& in_array($function->getName(), $constructors, true)
) {
continue;
}
$hasInitialization = $initializedPropertiesMap[$propertyName]->or($usageScope->hasExpressionType(new PropertyInitializationExpr($propertyName)));
if (!$hasInitialization->yes() && $usageScope->isInAnonymousFunction() && $usageScope->getParentScope() !== null) {
$hasInitialization = $hasInitialization->or($usageScope->getParentScope()->hasExpressionType(new PropertyInitializationExpr($propertyName)));
}
if (!$hasInitialization->yes()) {
$prematureAccess[] = [
$propertyName,
$fetch->getStartLine(),
$originalProperties[$propertyName],
$usageScope->getFile(),
$usageScope->getFileDescription(),
];
}
}
}
return [
$this->collectUninitializedProperties(array_keys($methodsCalledFromConstructor), $uninitializedProperties),
$prematureAccess,
$additionalAssigns,
];
}
/**
* @param list<string> $constructors
* @param array<string, ClassPropertyNode> $uninitializedProperties
* @return array<string, ClassPropertyNode>
*/
private function collectUninitializedProperties(array $constructors, array $uninitializedProperties): array
{
foreach ($constructors as $constructor) {
$lowerConstructorName = strtolower($constructor);
if (!array_key_exists($lowerConstructorName, $this->returnStatementNodes)) {
continue;
}
$returnStatementsNode = $this->returnStatementNodes[$lowerConstructorName];
$methodScope = null;
foreach ($returnStatementsNode->getExecutionEnds() as $executionEnd) {
$statementResult = $executionEnd->getStatementResult();
$endNode = $executionEnd->getNode();
if ($statementResult->isAlwaysTerminating()) {
if ($endNode instanceof Node\Stmt\Expression) {
$exprType = $statementResult->getScope()->getType($endNode->expr);
if ($exprType instanceof NeverType && $exprType->isExplicit()) {
continue;
}
}
}
if ($methodScope === null) {
$methodScope = $statementResult->getScope();
continue;
}
$methodScope = $methodScope->mergeWith($statementResult->getScope());
}
foreach ($returnStatementsNode->getReturnStatements() as $returnStatement) {
if ($methodScope === null) {
$methodScope = $returnStatement->getScope();
continue;
}
$methodScope = $methodScope->mergeWith($returnStatement->getScope());
}
if ($methodScope === null) {
continue;
}
foreach (array_keys($uninitializedProperties) as $propertyName) {
if (!$methodScope->hasExpressionType(new PropertyInitializationExpr($propertyName))->yes()) {
continue;
}
unset($uninitializedProperties[$propertyName]);
}
}
return $uninitializedProperties;
}
/**
* @param string[] $methods
* @param array<string, TrinaryLogic> $initialInitializedProperties
* @param array<string, array<string, TrinaryLogic>> $initializedProperties
* @param array<string, ClassPropertyNode> $initializedInConstructorProperties
*
* @return array<string, array<string, TrinaryLogic>>
*/
private function getMethodsCalledFromConstructor(
ClassReflection $classReflection,
array $initialInitializedProperties,
array $initializedProperties,
array $methods,
array $initializedInConstructorProperties,
): array
{
$originalMap = $initializedProperties;
$originalMethods = $methods;
foreach ($this->methodCalls as $methodCall) {
$methodCallNode = $methodCall->getNode();
if ($methodCallNode instanceof Array_) {
continue;
}
if (!$methodCallNode->name instanceof Identifier) {
continue;
}
$callScope = $methodCall->getScope();
if ($methodCallNode instanceof Node\Expr\MethodCall) {
$calledOnType = $callScope->getType($methodCallNode->var);
} else {
if (!$methodCallNode->class instanceof Name) {
continue;
}
$calledOnType = $callScope->resolveTypeByName($methodCallNode->class);
}
if (TypeUtils::findThisType($calledOnType) === null) {
continue;
}
$inMethod = $callScope->getFunction();
if (!$inMethod instanceof MethodReflection) {
continue;
}
if (!in_array($inMethod->getName(), $methods, true)) {
continue;
}
if ($inMethod->getName() !== '__construct') {
foreach ($initializedInConstructorProperties as $propertyName => $propertyNode) {
$initializedProperties[$inMethod->getName()][$propertyName] = TrinaryLogic::createYes();
}
}
$methodName = $methodCallNode->name->toString();
if (array_key_exists($methodName, $initializedProperties)) {
foreach ($this->getInitializedProperties($callScope, $initializedProperties[$inMethod->getName()] ?? $initialInitializedProperties) as $propertyName => $isInitialized) {
$initializedProperties[$methodName][$propertyName] = $initializedProperties[$methodName][$propertyName]->and($isInitialized);
}
continue;
}
$methodReflection = $callScope->getMethodReflection($calledOnType, $methodName);
if ($methodReflection === null) {
continue;
}
if ($methodReflection->getDeclaringClass()->getName() !== $classReflection->getName()) {
continue;
}
$initializedProperties[$methodName] = $this->getInitializedProperties($callScope, $initializedProperties[$inMethod->getName()] ?? $initialInitializedProperties);
$methods[] = $methodName;
}
if ($originalMap === $initializedProperties && $originalMethods === $methods) {
return $initializedProperties;
}
return $this->getMethodsCalledFromConstructor($classReflection, $initialInitializedProperties, $initializedProperties, $methods, $initializedInConstructorProperties);
}
/**
* @param array<string, TrinaryLogic> $initialInitializedProperties
* @return array<string, TrinaryLogic>
*/
private function getInitializedProperties(Scope $scope, array $initialInitializedProperties): array
{
foreach ($initialInitializedProperties as $propertyName => $isInitialized) {
$initialInitializedProperties[$propertyName] = $isInitialized->or($scope->hasExpressionType(new PropertyInitializationExpr($propertyName)));
}
return $initialInitializedProperties;
}
/**
* @return list<PropertyAssign>
*/
public function getPropertyAssigns(): array
{
return $this->propertyAssigns;
}
}