Do not allow @phpstan-self-out above static method

Author: ondrejmirtes

Diff for: src/Analyser/NodeScopeResolver.php

@@ -2649,7 +2649,7 @@ static function (): void {
 					$nodeCallback(new InvalidateExprNode($expr->var), $scope);
 					$scope = $scope->invalidateExpression($expr->var, true);
 				}
-				if ($parametersAcceptor !== null) {
+				if ($parametersAcceptor !== null && !$methodReflection->isStatic()) {
 					$selfOutType = $methodReflection->getSelfOutType();
 					if ($selfOutType !== null) {
 						$scope = $scope->assignExpression(

Diff for: src/Rules/PhpDoc/IncompatibleSelfOutTypeRule.php

@@ -34,19 +34,24 @@ public function processNode(Node $node, Scope $scope): array
 		$classReflection = $method->getDeclaringClass();
 		$classType = new ObjectType($classReflection->getName(), null, $classReflection);
 
-		if ($classType->isSuperTypeOf($selfOutType)->yes()) {
-			return [];
-		}
-
-		return [
-			RuleErrorBuilder::message(sprintf(
+		$errors = [];
+		if (!$classType->isSuperTypeOf($selfOutType)->yes()) {
+			$errors[] = RuleErrorBuilder::message(sprintf(
 				'Self-out type %s of method %s::%s is not subtype of %s.',
 				$selfOutType->describe(VerbosityLevel::precise()),
 				$classReflection->getName(),
 				$method->getName(),
 				$classType->describe(VerbosityLevel::precise()),
-			))->identifier('selfOut.type')->build(),
-		];
+			))->identifier('selfOut.type')->build();
+		}
+
+		if ($method->isStatic()) {
+			$errors[] = RuleErrorBuilder::message(sprintf('PHPDoc tag @phpstan-self-out is not supported above static method %s::%s().', $classReflection->getName(), $method->getName()))
+				->identifier('selfOut.static')
+				->build();
+		}
+
+		return $errors;
 	}
 
 }

Diff for: tests/PHPStan/Analyser/nsrt/self-out.php

@@ -50,6 +50,14 @@ public function setData($data) {
      */
     public function test(): void {
     }
+
+	/**
+	 * @phpstan-self-out self<false>
+	 */
+	public static function selfOutWithStaticMethod(): void
+	{
+
+	}
 }
 
 /**
@@ -94,4 +102,7 @@ function () {
 
 	$i->setData(true);
 	assertType('SelfOut\\a<true>', $i);
+
+	$i->selfOutWithStaticMethod();
+	assertType('SelfOut\\a<true>', $i);
 };

Diff for: tests/PHPStan/Rules/PhpDoc/IncompatibleSelfOutTypeRuleTest.php

@@ -27,6 +27,10 @@ public function testRule(): void
 				'Self-out type IncompatibleSelfOutType\A|null of method IncompatibleSelfOutType\A::four is not subtype of IncompatibleSelfOutType\A.',
 				28,
 			],
+			[
+				'PHPDoc tag @phpstan-self-out is not supported above static method IncompatibleSelfOutType\Foo::selfOutStatic().',
+				38,
+			],
 		]);
 	}
 

Diff for: tests/PHPStan/Rules/PhpDoc/data/incompatible-self-out-type.php

@@ -27,3 +27,17 @@ public function three();
 	 */
 	public function four();
 }
+
+/**
+ * @template T
+ */
+class Foo
+{
+
+	/** @phpstan-self-out self<int> */
+	public static function selfOutStatic(): void
+	{
+
+	}
+
+}