Skip to content

Commit 31f6737

Browse files
mvorisekondrejmirtes
mvorisek
authored and
ondrejmirtes
committed
Fix late static binding calls
1 parent ae23a92 commit 31f6737

File tree

2 files changed

+166
-0
lines changed

2 files changed

+166
-0
lines changed

‎src/Analyser/MutatingScope.php

+24
Original file line numberDiff line numberDiff line change
@@ -2083,6 +2083,18 @@ static function (Node $node, Scope $scope) use ($arrowScope, &$arrowFunctionImpu
20832083
$typeCallback = function () use ($node): Type {
20842084
if ($node->class instanceof Name) {
20852085
$staticMethodCalledOnType = $this->resolveTypeByName($node->class);
2086+
if (
2087+
$staticMethodCalledOnType instanceof StaticType
2088+
&& !in_array($node->class->toLowerString(), ['self', 'static', 'parent'], true)
2089+
) {
2090+
$methodReflectionCandidate = $this->getMethodReflection(
2091+
$staticMethodCalledOnType,
2092+
$node->name->name,
2093+
);
2094+
if ($methodReflectionCandidate !== null && $methodReflectionCandidate->isStatic()) {
2095+
$staticMethodCalledOnType = $staticMethodCalledOnType->getStaticObjectType();
2096+
}
2097+
}
20862098
} else {
20872099
$staticMethodCalledOnType = $this->getNativeType($node->class);
20882100
}
@@ -2108,6 +2120,18 @@ static function (Node $node, Scope $scope) use ($arrowScope, &$arrowFunctionImpu
21082120
$typeCallback = function () use ($node): Type {
21092121
if ($node->class instanceof Name) {
21102122
$staticMethodCalledOnType = $this->resolveTypeByName($node->class);
2123+
if (
2124+
$staticMethodCalledOnType instanceof StaticType
2125+
&& !in_array($node->class->toLowerString(), ['self', 'static', 'parent'], true)
2126+
) {
2127+
$methodReflectionCandidate = $this->getMethodReflection(
2128+
$staticMethodCalledOnType,
2129+
$node->name->name,
2130+
);
2131+
if ($methodReflectionCandidate !== null && $methodReflectionCandidate->isStatic()) {
2132+
$staticMethodCalledOnType = $staticMethodCalledOnType->getStaticObjectType();
2133+
}
2134+
}
21112135
} else {
21122136
$staticMethodCalledOnType = TypeCombinator::removeNull($this->getType($node->class))->getObjectTypeOrClassStringObjectType();
21132137
}

‎tests/PHPStan/Analyser/nsrt/static-late-binding.php

+142
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,142 @@
1+
<?php
2+
3+
namespace StaticLateBinding;
4+
5+
use function PHPStan\Testing\assertType;
6+
7+
class A
8+
{
9+
public static function retStaticConst(): int
10+
{
11+
return 1;
12+
}
13+
14+
/**
15+
* @return static
16+
*/
17+
public static function retStatic()
18+
{
19+
return new static();
20+
}
21+
22+
/**
23+
* @return static
24+
*/
25+
public function retNonStatic()
26+
{
27+
return new static();
28+
}
29+
30+
/**
31+
* @param-out int $out
32+
*/
33+
public static function outStaticConst(&$out): int
34+
{
35+
$out = 1;
36+
}
37+
}
38+
39+
class B extends A
40+
{
41+
/**
42+
* @return 2
43+
*/
44+
public static function retStaticConst(): int
45+
{
46+
return 2;
47+
}
48+
49+
/**
50+
* @param-out 2 $out
51+
*/
52+
public static function outStaticConst(&$out): int
53+
{
54+
$out = 2;
55+
}
56+
57+
public function foo(): void
58+
{
59+
$clUnioned = mt_rand() === 0
60+
? A::class
61+
: X::class;
62+
63+
assertType('int', A::retStaticConst());
64+
assertType('2', B::retStaticConst());
65+
assertType('2', self::retStaticConst());
66+
assertType('2', static::retStaticConst());
67+
assertType('int', parent::retStaticConst());
68+
assertType('2', $this->retStaticConst());
69+
assertType('bool', X::retStaticConst());
70+
assertType('*ERROR*', $clUnioned->retStaticConst()); // should be bool|int
71+
72+
assertType('int', A::retStaticConst(...)());
73+
assertType('2', B::retStaticConst(...)());
74+
assertType('2', self::retStaticConst(...)());
75+
assertType('2', static::retStaticConst(...)());
76+
assertType('int', parent::retStaticConst(...)());
77+
assertType('2', $this->retStaticConst(...)());
78+
assertType('bool', X::retStaticConst(...)());
79+
assertType('mixed', $clUnioned->retStaticConst(...)()); // should be bool|int
80+
81+
assertType('StaticLateBinding\A', A::retStatic());
82+
assertType('StaticLateBinding\B', B::retStatic());
83+
assertType('static(StaticLateBinding\B)', self::retStatic());
84+
assertType('static(StaticLateBinding\B)', static::retStatic());
85+
assertType('static(StaticLateBinding\B)', parent::retStatic());
86+
assertType('static(StaticLateBinding\B)', $this->retStatic());
87+
assertType('bool', X::retStatic());
88+
assertType('bool|StaticLateBinding\A|StaticLateBinding\X', $clUnioned::retStatic()); // should be bool|StaticLateBinding\A
89+
90+
assertType('static(StaticLateBinding\B)', A::retNonStatic());
91+
assertType('static(StaticLateBinding\B)', B::retNonStatic());
92+
assertType('static(StaticLateBinding\B)', self::retNonStatic());
93+
assertType('static(StaticLateBinding\B)', static::retNonStatic());
94+
assertType('static(StaticLateBinding\B)', parent::retNonStatic());
95+
assertType('static(StaticLateBinding\B)', $this->retNonStatic());
96+
assertType('bool', X::retNonStatic());
97+
assertType('*ERROR*', $clUnioned->retNonStatic()); // should be bool|static(StaticLateBinding\B)
98+
99+
A::outStaticConst($v);
100+
assertType('int', $v);
101+
B::outStaticConst($v);
102+
assertType('2', $v);
103+
self::outStaticConst($v);
104+
assertType('2', $v);
105+
static::outStaticConst($v);
106+
assertType('2', $v);
107+
parent::outStaticConst($v);
108+
assertType('int', $v);
109+
$this->outStaticConst($v);
110+
assertType('2', $v);
111+
X::outStaticConst($v);
112+
assertType('bool', $v);
113+
$clUnioned->outStaticConst($v);
114+
assertType('bool', $v); // should be bool|int
115+
}
116+
}
117+
118+
class X
119+
{
120+
public static function retStaticConst(): bool
121+
{
122+
return false;
123+
}
124+
125+
/**
126+
* @param-out bool $out
127+
*/
128+
public static function outStaticConst(&$out): void
129+
{
130+
$out = false;
131+
}
132+
133+
public static function retStatic(): bool
134+
{
135+
return false;
136+
}
137+
138+
public function retNonStatic(): bool
139+
{
140+
return false;
141+
}
142+
}

0 commit comments

Comments
 (0)