Fix missing ltrim in regex parse

Author: mvorisek

src/Type/Regex/RegexExpressionHelper.php

@@ -88,6 +88,8 @@ public function getPatternModifiers(string $pattern): ?string
 
 	public function removeDelimitersAndModifiers(string $pattern): string
 	{
+		$pattern = ltrim($pattern);
+
 		$endDelimiterPos = $this->getEndDelimiterPos($pattern);
 
 		if ($endDelimiterPos === false) {

tests/PHPStan/Analyser/nsrt/preg_match_shapes.php

@@ -768,3 +768,13 @@ function bug11604b (string $string): void {
 		assertType("array{0: string, 1?: ''|'XX', 2?: ''|'YY', 3?: 'ZZ'}", $matches);
 	}
 }
+
+function testLtrimDelimiter (string $string): void {
+	if (preg_match(' /(x)/', $string, $matches)) {
+		assertType("array{string, 'x'}", $matches);
+	}
+
+	if (preg_match('  /(x)/', $string, $matches)) {
+		assertType("array{string, 'x'}", $matches);
+	}
+}

tests/PHPStan/Type/Regex/RegexExpressionHelperTest.php

@@ -0,0 +1,61 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Type\Regex;
+
+use PHPStan\Testing\PHPStanTestCase;
+
+class RegexExpressionHelperTest extends PHPStanTestCase
+{
+
+	public function dataRemoveDelimitersAndModifiers(): array
+	{
+		return [
+			[
+				'/x/',
+				'x',
+			],
+			[
+				'~x~',
+				'x',
+			],
+			[
+				'~~',
+				'',
+			],
+			[
+				'~x~is',
+				'x',
+			],
+			[
+				' ~x~',
+				'x',
+			],
+			[
+				'  ~x~  ',
+				'x',
+			],
+			[
+				'[x]',
+				'x',
+			],
+			[
+				'{x}mx',
+				'x',
+			],
+		];
+	}
+
+	/**
+	 * @dataProvider dataRemoveDelimitersAndModifiers
+	 */
+	public function testRemoveDelimitersAndModifiers(string $inputPattern, string $expectedPatternWithoutDelimiter): void
+	{
+		$regexExpressionHelper = self::getContainer()->getByType(RegexExpressionHelper::class);
+
+		$this->assertSame(
+			$expectedPatternWithoutDelimiter,
+			$regexExpressionHelper->removeDelimitersAndModifiers($inputPattern),
+		);
+	}
+
+}