str_split returns an empty array since PHP 8.2

Author: herndlm

resources/functionMap_php82delta.php

@@ -0,0 +1,29 @@
+<?php // phpcs:ignoreFile
+
+/**
+ * Copied over from https://github.com/phan/phan/blob/8866d6b98be94b37996390da226e8c4befea29aa/src/Phan/Language/Internal/FunctionSignatureMap_php80_delta.php
+ * Copyright (c) 2015 Rasmus Lerdorf
+ * Copyright (c) 2015 Andrew Morrison
+ */
+
+/**
+ * This contains the information needed to convert the function signatures for php 8.0 to php 7.4 (and vice versa)
+ *
+ * This has two sections.
+ * The 'new' section contains function/method names from FunctionSignatureMap (And alternates, if applicable) that do not exist in php7.4 or have different signatures in php 8.0.
+ *   If they were just updated, the function/method will be present in the 'added' signatures.
+ * The 'old' signatures contains the signatures that are different in php 7.4.
+ *   Functions are expected to be removed only in major releases of php.
+ *
+ * @see FunctionSignatureMap.php
+ *
+ * @phan-file-suppress PhanPluginMixedKeyNoKey (read by Phan when analyzing this file)
+ */
+return [
+	'new' => [
+		'str_split' => ['array<int,string>', 'str'=>'string', 'split_length='=>'positive-int'],
+	],
+	'old' => [
+
+	]
+];

src/Php/PhpVersion.php

@@ -196,4 +196,9 @@ public function deprecatesDynamicProperties(): bool
 		return $this->versionId >= 80200;
 	}
 
+	public function strSplitReturnsEmptyArray(): bool
+	{
+		return $this->versionId >= 80200;
+	}
+
 }

src/Reflection/SignatureMap/FunctionSignatureMapProvider.php

@@ -204,6 +204,15 @@ public function getSignatureMap(): array
 				$signatureMap = $this->computeSignatureMap($signatureMap, $php81MapDelta);
 			}
 
+			if ($this->phpVersion->getVersionId() >= 80200) {
+				$php82MapDelta = require __DIR__ . '/../../../resources/functionMap_php82delta.php';
+				if (!is_array($php82MapDelta)) {
+					throw new ShouldNotHappenException('Signature map could not be loaded.');
+				}
+
+				$signatureMap = $this->computeSignatureMap($signatureMap, $php82MapDelta);
+			}
+
 			$this->signatureMap = $signatureMap;
 		}
 

src/Type/Php/StrSplitFunctionReturnTypeExtension.php

@@ -90,15 +90,15 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection,
 
 		$stringType = $scope->getType($functionCall->getArgs()[0]->value);
 
-		return TypeTraverser::map($stringType, static function (Type $type, callable $traverse) use ($encoding, $splitLength, $scope): Type {
+		return TypeTraverser::map($stringType, function (Type $type, callable $traverse) use ($encoding, $splitLength, $scope): Type {
 			if ($type instanceof UnionType || $type instanceof IntersectionType) {
 				return $traverse($type);
 			}
 
 			if (!$type instanceof ConstantStringType) {
 				$returnType = new ArrayType(new IntegerType(), new StringType());
 
-				return $encoding === null
+				return $encoding === null && !$this->phpVersion->strSplitReturnsEmptyArray()
 					? TypeCombinator::intersect($returnType, new NonEmptyArrayType())
 					: $returnType;
 			}

tests/PHPStan/Analyser/LegacyNodeScopeResolverTest.php

@@ -5138,6 +5138,14 @@ public function testArrayFunctions(
 
 	public function dataFunctions(): array
 	{
+		$strSplitDefaultReturnType = 'non-empty-array<int, string>|false';
+		if (PHP_VERSION_ID >= 80000) {
+			$strSplitDefaultReturnType = 'non-empty-array<int, string>';
+		}
+		if (PHP_VERSION_ID >= 80200) {
+			$strSplitDefaultReturnType = 'array<int, string>';
+		}
+
 		return [
 			[
 				'string',
@@ -5328,15 +5336,15 @@ public function dataFunctions(): array
 				'$gettimeofdayBenevolent',
 			],
 			[
-				PHP_VERSION_ID < 80000 ? 'non-empty-array<int, string>|false' : 'non-empty-array<int, string>',
+				$strSplitDefaultReturnType,
 				'$strSplitConstantStringWithoutDefinedParameters',
 			],
 			[
 				'array{\'a\', \'b\', \'c\', \'d\', \'e\', \'f\'}',
 				'$strSplitConstantStringWithoutDefinedSplitLength',
 			],
 			[
-				'non-empty-array<int, string>',
+				PHP_VERSION_ID < 80200 ? 'non-empty-array<int, string>' : 'array<int, string>',
 				'$strSplitStringWithoutDefinedSplitLength',
 			],
 			[
@@ -5352,15 +5360,15 @@ public function dataFunctions(): array
 				'$strSplitConstantStringWithFailureSplitLength',
 			],
 			[
-				PHP_VERSION_ID < 80000 ? 'non-empty-array<int, string>|false' : 'non-empty-array<int, string>',
+				$strSplitDefaultReturnType,
 				'$strSplitConstantStringWithInvalidSplitLengthType',
 			],
 			[
 				'array{\'a\'|\'g\', \'b\'|\'h\', \'c\'|\'i\', \'d\'|\'j\', \'e\'|\'k\', \'f\'|\'l\'}',
 				'$strSplitConstantStringWithVariableStringAndConstantSplitLength',
 			],
 			[
-				PHP_VERSION_ID < 80000 ? 'non-empty-array<int, string>|false' : 'non-empty-array<int, string>',
+				$strSplitDefaultReturnType,
 				'$strSplitConstantStringWithVariableStringAndVariableSplitLength',
 			],
 			// parse_url