AnalyseApplication - call CollectedDataNode rules

Author: ondrejmirtes

Diff for: src/Command/AnalyseApplication.php

@@ -2,12 +2,24 @@
 
 namespace PHPStan\Command;
 
+use PHPStan\AnalysedCodeException;
 use PHPStan\Analyser\AnalyserResult;
+use PHPStan\Analyser\Error;
 use PHPStan\Analyser\IgnoredErrorHelper;
 use PHPStan\Analyser\ResultCache\ResultCacheManagerFactory;
+use PHPStan\Analyser\RuleErrorTransformer;
+use PHPStan\Analyser\ScopeContext;
+use PHPStan\Analyser\ScopeFactory;
+use PHPStan\BetterReflection\NodeCompiler\Exception\UnableToCompileNode;
+use PHPStan\BetterReflection\Reflection\Exception\NotAClassReflection;
+use PHPStan\BetterReflection\Reflection\Exception\NotAnInterfaceReflection;
+use PHPStan\BetterReflection\Reflector\Exception\IdentifierNotFound;
+use PHPStan\Collectors\CollectedData;
 use PHPStan\Internal\BytesHelper;
+use PHPStan\Node\CollectedDataNode;
 use PHPStan\PhpDoc\StubFilesProvider;
 use PHPStan\PhpDoc\StubValidator;
+use PHPStan\Rules\Registry as RuleRegistry;
 use PHPStan\ShouldNotHappenException;
 use Symfony\Component\Console\Input\InputInterface;
 use function array_merge;
@@ -27,6 +39,9 @@ public function __construct(
 		private IgnoredErrorHelper $ignoredErrorHelper,
 		private int $internalErrorsCountLimit,
 		private StubFilesProvider $stubFilesProvider,
+		private RuleRegistry $ruleRegistry,
+		private ScopeFactory $scopeFactory,
+		private RuleErrorTransformer $ruleErrorTransformer,
 	)
 	{
 	}
@@ -87,7 +102,11 @@ public function analyse(
 			$resultCacheResult = $resultCacheManager->process($intermediateAnalyserResult, $resultCache, $errorOutput, $onlyFiles, true);
 			$analyserResult = $resultCacheResult->getAnalyserResult();
 			$internalErrors = $analyserResult->getInternalErrors();
-			$errors = $ignoredErrorHelperResult->process($analyserResult->getErrors(), $onlyFiles, $files, count($internalErrors) > 0 || $analyserResult->hasReachedInternalErrorsCountLimit());
+			$errors = $analyserResult->getErrors();
+			foreach ($this->getCollectedDataErrors($analyserResult->getCollectedData()) as $error) {
+				$errors[] = $error;
+			}
+			$errors = $ignoredErrorHelperResult->process($errors, $onlyFiles, $files, count($internalErrors) > 0 || $analyserResult->hasReachedInternalErrorsCountLimit());
 			$collectedData = $analyserResult->getCollectedData();
 			$savedResultCache = $resultCacheResult->isSaved();
 			if ($analyserResult->hasReachedInternalErrorsCountLimit()) {
@@ -119,6 +138,39 @@ public function analyse(
 		);
 	}
 
+	/**
+	 * @param CollectedData[] $collectedData
+	 * @return Error[]
+	 */
+	private function getCollectedDataErrors(array $collectedData): array
+	{
+		$nodeType = CollectedDataNode::class;
+		$node = new CollectedDataNode($collectedData);
+		$file = 'N/A';
+		$scope = $this->scopeFactory->create(ScopeContext::create($file));
+		$errors = [];
+		foreach ($this->ruleRegistry->getRules($nodeType) as $rule) {
+			try {
+				$ruleErrors = $rule->processNode($node, $scope);
+			} catch (AnalysedCodeException $e) {
+				$errors[] = new Error($e->getMessage(), $file, $node->getLine(), $e, null, null, $e->getTip());
+				continue;
+			} catch (IdentifierNotFound $e) {
+				$errors[] = new Error(sprintf('Reflection error: %s not found.', $e->getIdentifier()->getName()), $file, $node->getLine(), $e, null, null, 'Learn more at https://phpstan.org/user-guide/discovering-symbols');
+				continue;
+			} catch (UnableToCompileNode | NotAClassReflection | NotAnInterfaceReflection $e) {
+				$errors[] = new Error(sprintf('Reflection error: %s', $e->getMessage()), $file, $node->getLine(), $e);
+				continue;
+			}
+
+			foreach ($ruleErrors as $ruleError) {
+				$errors[] = $this->ruleErrorTransformer->transform($ruleError, $scope, $nodeType, $node->getLine());
+			}
+		}
+
+		return $errors;
+	}
+
 	/**
 	 * @param string[] $files
 	 * @param string[] $allAnalysedFiles