Fix wrongly convertion of list<T> to array{T}

Author: staabm

src/Analyser/TypeSpecifier.php

@@ -1059,7 +1059,8 @@ private function turnListIntoConstantArray(FuncCall $countFuncCall, Type $type,
 					}
 					$valueTypesBuilder->setOffsetValueType($offsetType, $type->getOffsetValueType($offsetType), !$hasOffset->yes());
 				}
-
+			} else {
+				return null;
 			}
 
 			$arrayType = $valueTypesBuilder->getArray();

tests/PHPStan/Analyser/nsrt/bug-11642.php

@@ -0,0 +1,44 @@
+<?php declare(strict_types = 1);
+
+namespace Bug11642;
+
+use function PHPStan\Testing\assertType;
+
+class Repository
+{
+	/**
+	 * @psalm-param array<string|int, mixed> $criteria
+	 *
+	 * @return object[] The objects.
+	 * @psalm-return list<\stdClass>
+	 */
+	function findBy(array $criteria): array
+	{
+		return [new \stdClass, new \stdCLass, new \stdClass, new \stdClass];
+	}
+}
+
+class Payload {
+	/** @var non-empty-list<string> */
+	public array $ids = ['one', 'two'];
+}
+
+function doFoo() {
+	$payload = new Payload();
+
+	$fetcher = new Repository();
+	$entries = $fetcher->findBy($payload->ids);
+	assertType('list<stdClass>', $entries);
+	assertType('int<0, max>', count($entries));
+	assertType('int<1, max>', count($payload->ids));
+	if (count($entries) !== count($payload->ids)) {
+		exit();
+	}
+
+	assertType('non-empty-list<stdClass>', $entries);
+	if (count($entries) > 3) {
+		throw new \RuntimeException();
+	}
+
+	assertType('non-empty-list<stdClass>', $entries);
+}