Modernized InFunctionNode rules

Author: ondrejmirtes

Diff for: src/Rules/Functions/ExistingClassesInTypehintsRule.php

@@ -6,7 +6,6 @@
 use PHPStan\Analyser\Scope;
 use PHPStan\Internal\SprintfHelper;
 use PHPStan\Node\InFunctionNode;
-use PHPStan\Reflection\Php\PhpFunctionFromParserNodeReflection;
 use PHPStan\Rules\FunctionDefinitionCheck;
 use PHPStan\Rules\Rule;
 use function sprintf;
@@ -28,15 +27,11 @@ public function getNodeType(): string
 
 	public function processNode(Node $node, Scope $scope): array
 	{
-		if (!$scope->getFunction() instanceof PhpFunctionFromParserNodeReflection) {
-			return [];
-		}
-
-		$functionName = SprintfHelper::escapeFormatString($scope->getFunction()->getName());
+		$functionName = SprintfHelper::escapeFormatString($node->getFunctionReflection()->getName());
 
 		return $this->check->checkFunction(
 			$node->getOriginalNode(),
-			$scope->getFunction(),
+			$node->getFunctionReflection(),
 			sprintf(
 				'Parameter $%%s of function %s() has invalid type %%s.',
 				$functionName,

Diff for: src/Rules/Functions/MissingFunctionParameterTypehintRule.php

@@ -8,7 +8,6 @@
 use PHPStan\Reflection\FunctionReflection;
 use PHPStan\Reflection\ParameterReflection;
 use PHPStan\Reflection\ParametersAcceptorSelector;
-use PHPStan\Reflection\Php\PhpFunctionFromParserNodeReflection;
 use PHPStan\Rules\MissingTypehintCheck;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleError;
@@ -37,11 +36,7 @@ public function getNodeType(): string
 
 	public function processNode(Node $node, Scope $scope): array
 	{
-		$functionReflection = $scope->getFunction();
-		if (!$functionReflection instanceof PhpFunctionFromParserNodeReflection) {
-			return [];
-		}
-
+		$functionReflection = $node->getFunctionReflection();
 		$messages = [];
 
 		foreach (ParametersAcceptorSelector::selectSingle($functionReflection->getVariants())->getParameters() as $parameterReflection) {

Diff for: src/Rules/Functions/MissingFunctionReturnTypehintRule.php

@@ -6,7 +6,6 @@
 use PHPStan\Analyser\Scope;
 use PHPStan\Node\InFunctionNode;
 use PHPStan\Reflection\ParametersAcceptorSelector;
-use PHPStan\Reflection\Php\PhpFunctionFromParserNodeReflection;
 use PHPStan\Rules\MissingTypehintCheck;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
@@ -34,11 +33,7 @@ public function getNodeType(): string
 
 	public function processNode(Node $node, Scope $scope): array
 	{
-		$functionReflection = $scope->getFunction();
-		if (!$functionReflection instanceof PhpFunctionFromParserNodeReflection) {
-			return [];
-		}
-
+		$functionReflection = $node->getFunctionReflection();
 		$returnType = ParametersAcceptorSelector::selectSingle($functionReflection->getVariants())->getReturnType();
 
 		if ($returnType instanceof MixedType && !$returnType->isExplicitMixed()) {

Diff for: src/Rules/Generics/FunctionSignatureVarianceRule.php

@@ -27,11 +27,7 @@ public function getNodeType(): string
 
 	public function processNode(Node $node, Scope $scope): array
 	{
-		$functionReflection = $scope->getFunction();
-		if ($functionReflection === null) {
-			return [];
-		}
-
+		$functionReflection = $node->getFunctionReflection();
 		$functionName = $functionReflection->getName();
 
 		return $this->varianceCheck->checkParametersAcceptor(

Diff for: src/Rules/PhpDoc/FunctionAssertRule.php

@@ -6,7 +6,6 @@
 use PHPStan\Analyser\Scope;
 use PHPStan\Node\InFunctionNode;
 use PHPStan\Rules\Rule;
-use PHPStan\ShouldNotHappenException;
 use function count;
 
 /**
@@ -26,11 +25,7 @@ public function getNodeType(): string
 
 	public function processNode(Node $node, Scope $scope): array
 	{
-		$function = $scope->getFunction();
-		if ($function === null) {
-			throw new ShouldNotHappenException();
-		}
-
+		$function = $node->getFunctionReflection();
 		$variants = $function->getVariants();
 		if (count($variants) !== 1) {
 			return [];

Diff for: src/Rules/PhpDoc/FunctionConditionalReturnTypeRule.php

@@ -6,7 +6,6 @@
 use PHPStan\Analyser\Scope;
 use PHPStan\Node\InFunctionNode;
 use PHPStan\Rules\Rule;
-use PHPStan\ShouldNotHappenException;
 use function count;
 
 /**
@@ -26,12 +25,8 @@ public function getNodeType(): string
 
 	public function processNode(Node $node, Scope $scope): array
 	{
-		$method = $scope->getFunction();
-		if ($method === null) {
-			throw new ShouldNotHappenException();
-		}
-
-		$variants = $method->getVariants();
+		$function = $node->getFunctionReflection();
+		$variants = $function->getVariants();
 		if (count($variants) !== 1) {
 			return [];
 		}