fixup! Replace error-prone instanceof in Rules classes

zonuexe · zonuexe · commit bbbe15f705db · 2025-03-07T01:39:47.000+09:00
diff --git a/src/Rules/Variables/CompactVariablesRule.php b/src/Rules/Variables/CompactVariablesRule.php
@@ -70,11 +70,11 @@ public function processNode(Node $node, Scope $scope): array
 	 */
 	private function findConstantStrings(Type $type): array
 	{
-		if (count($type->getConstantStrings()) > 0) {
+		if (count($type->getConstantStrings()) === 1) {
 			return $type->getConstantStrings();
 		}
 
-		if (count($type->getConstantArrays()) > 1) {
+		if (count($type->getConstantArrays()) === 1) {
 			$result = [];
 			foreach ($type->getConstantArrays()[0]->getValueTypes() as $valueType) {
 				$constantStrings = $this->findConstantStrings($valueType);

Original file line number	Diff line number	Diff line change
`@@ -70,11 +70,11 @@ public function processNode(Node $node, Scope $scope): array`
`70`	`70`	`*/`
`71`	`71`	`private function findConstantStrings(Type $type): array`
`72`	`72`	`{`
`73`		`- if (count($type->getConstantStrings()) > 0) {`
	`73`	`+ if (count($type->getConstantStrings()) === 1) {`
`74`	`74`	`return $type->getConstantStrings();`
`75`	`75`	`}`
`76`	`76`
`77`		`- if (count($type->getConstantArrays()) > 1) {`
	`77`	`+ if (count($type->getConstantArrays()) === 1) {`
`78`	`78`	`$result = [];`
`79`	`79`	`foreach ($type->getConstantArrays()[0]->getValueTypes() as $valueType) {`
`80`	`80`	`$constantStrings = $this->findConstantStrings($valueType);`