Proper test for StringType::setOffsetValueType()

ondrejmirtes · ondrejmirtes · commit c19155c3310e · 2024-08-14T21:35:18.000+02:00
diff --git a/tests/PHPStan/Analyser/nsrt/bug-3981.php b/tests/PHPStan/Analyser/nsrt/bug-3981.php
@@ -20,6 +20,11 @@ public function doFoo(string $s, string $nonEmptyString): void
 		assertType('non-empty-string', $nonEmptyString[0]);
 		assertType('non-empty-string', $nonEmptyString[1]);
 		assertType('non-empty-string', $s[0]);
+
+		assertType('string', $s);
+
+		$s[0] = '1';
+		assertType('non-empty-string', $s);
 	}
 
 }

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,11 @@ public function doFoo(string $s, string $nonEmptyString): void`
`20`	`20`	`assertType('non-empty-string', $nonEmptyString[0]);`
`21`	`21`	`assertType('non-empty-string', $nonEmptyString[1]);`
`22`	`22`	`assertType('non-empty-string', $s[0]);`
	`23`	`+`
	`24`	`+ assertType('string', $s);`
	`25`	`+`
	`26`	`+ $s[0] = '1';`
	`27`	`+ assertType('non-empty-string', $s);`
`23`	`28`	`}`
`24`	`29`
`25`	`30`	`}`