InFunctionNode always contains PhpFunctionFromParserNodeReflection

Author: ondrejmirtes

Diff for: src/Analyser/NodeScopeResolver.php

@@ -118,6 +118,7 @@
 use PHPStan\Reflection\ParameterReflectionWithPhpDocs;
 use PHPStan\Reflection\ParametersAcceptor;
 use PHPStan\Reflection\ParametersAcceptorSelector;
+use PHPStan\Reflection\Php\PhpFunctionFromParserNodeReflection;
 use PHPStan\Reflection\Php\PhpMethodFromParserNodeReflection;
 use PHPStan\Reflection\Php\PhpMethodReflection;
 use PHPStan\Reflection\ReflectionProvider;
@@ -443,7 +444,7 @@ private function processStmtNode(
 				$phpDocParameterOutTypes,
 			);
 			$functionReflection = $functionScope->getFunction();
-			if (!$functionReflection instanceof FunctionReflection) {
+			if (!$functionReflection instanceof PhpFunctionFromParserNodeReflection) {
 				throw new ShouldNotHappenException();
 			}
 

Diff for: src/Node/InFunctionNode.php

@@ -3,21 +3,21 @@
 namespace PHPStan\Node;
 
 use PhpParser\Node;
-use PHPStan\Reflection\FunctionReflection;
+use PHPStan\Reflection\Php\PhpFunctionFromParserNodeReflection;
 
 /** @api */
 class InFunctionNode extends Node\Stmt implements VirtualNode
 {
 
 	public function __construct(
-		private FunctionReflection $functionReflection,
+		private PhpFunctionFromParserNodeReflection $functionReflection,
 		private Node\Stmt\Function_ $originalNode,
 	)
 	{
 		parent::__construct($originalNode->getAttributes());
 	}
 
-	public function getFunctionReflection(): FunctionReflection
+	public function getFunctionReflection(): PhpFunctionFromParserNodeReflection
 	{
 		return $this->functionReflection;
 	}