Skip to content

Commit f85a500

Browse files
committed
MethodParameterComparisonHelper - parameter $ignorable of compare() method made required
1 parent 4937527 commit f85a500

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

Diff for: src/Rules/Methods/MethodParameterComparisonHelper.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public function __construct(private PhpVersion $phpVersion, private bool $generi
3131
/**
3232
* @return list<IdentifierRuleError>
3333
*/
34-
public function compare(ExtendedMethodReflection $prototype, ClassReflection $prototypeDeclaringClass, PhpMethodFromParserNodeReflection $method, bool $ignorable = false): array
34+
public function compare(ExtendedMethodReflection $prototype, ClassReflection $prototypeDeclaringClass, PhpMethodFromParserNodeReflection $method, bool $ignorable): array
3535
{
3636
/** @var list<IdentifierRuleError> $messages */
3737
$messages = [];

Diff for: src/Rules/Methods/OverridingMethodRule.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ public function processNode(Node $node, Scope $scope): array
233233
}
234234
}
235235

236-
$messages = array_merge($messages, $this->methodParameterComparisonHelper->compare($prototype, $prototypeDeclaringClass, $method));
236+
$messages = array_merge($messages, $this->methodParameterComparisonHelper->compare($prototype, $prototypeDeclaringClass, $method, false));
237237

238238
if (!$prototypeVariant instanceof FunctionVariantWithPhpDocs) {
239239
return $this->addErrors($messages, $node, $scope);

0 commit comments

Comments
 (0)