Simplified MissingPropertyTypehintRule

Author: ondrejmirtes

Diff for: src/Rules/Properties/MissingPropertyTypehintRule.php

@@ -4,7 +4,6 @@
 
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
-use PHPStan\Reflection\PropertyReflection;
 use PHPStan\Type\MixedType;
 
 final class MissingPropertyTypehintRule implements \PHPStan\Rules\Rule
@@ -31,30 +30,18 @@ public function processNode(Node $node, Scope $scope): array
 		}
 
 		$propertyReflection = $scope->getClassReflection()->getNativeProperty($node->name);
-
-		$messages = [];
-
-		$message = $this->checkPropertyType($node->name, $propertyReflection);
-		if ($message !== null) {
-			$messages[] = $message;
-		}
-
-		return $messages;
-	}
-
-	private function checkPropertyType(string $propertyName, PropertyReflection $propertyReflection): ?string
-	{
 		$returnType = $propertyReflection->getType();
-
 		if ($returnType instanceof MixedType && !$returnType->isExplicitMixed()) {
-			return sprintf(
-				'Property %s::$%s has no typehint specified',
-				$propertyReflection->getDeclaringClass()->getName(),
-				$propertyName
-			);
+			return [
+				sprintf(
+					'Property %s::$%s has no typehint specified',
+					$propertyReflection->getDeclaringClass()->getName(),
+					$node->name
+				),
+			];
 		}
 
-		return null;
+		return [];
 	}
 
 }