Check whether function parameter has typehint

Author: adaamz

Diff for: composer.json

@@ -29,6 +29,9 @@
 		}
 	},
 	"autoload-dev": {
-		"classmap": ["tests/"]
+		"classmap": ["tests/"],
+		"files": [
+			"tests/Rules/Functions/data/missing-function-parameter-typehint.php"
+		]
 	}
 }

Diff for: rules.neon

@@ -14,6 +14,7 @@ rules:
 	- PHPStan\Rules\BooleansInConditions\BooleanInTernaryOperatorRule
 	- PHPStan\Rules\DisallowedConstructs\DisallowedEmptyRule
 	- PHPStan\Rules\DisallowedConstructs\DisallowedImplicitArrayCreationRule
+	- PHPStan\Rules\Functions\MissingFunctionParameterTypehintRule
 	- PHPStan\Rules\Methods\MissingMethodParameterTypehintRule
 	- PHPStan\Rules\Methods\MissingMethodReturnTypehintRule
 	- PHPStan\Rules\Methods\WrongCaseOfInheritedMethodRule

Diff for: src/Rules/Functions/MissingFunctionParameterTypehintRule.php

@@ -0,0 +1,67 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Functions;
+
+use PhpParser\Node;
+use PHPStan\Analyser\Scope;
+use PHPStan\Broker\Broker;
+use PHPStan\Reflection\FunctionReflection;
+use PHPStan\Reflection\ParameterReflection;
+use PHPStan\Type\MixedType;
+
+final class MissingFunctionParameterTypehintRule implements \PHPStan\Rules\Rule
+{
+
+	/** @var Broker */
+	private $broker;
+
+	public function __construct(Broker $broker)
+    {
+        $this->broker = $broker;
+    }
+
+    public function getNodeType(): string
+	{
+		return \PhpParser\Node\Stmt\Function_::class;
+	}
+
+	/**
+	 * @param \PhpParser\Node\Stmt\Function_ $node
+	 * @param \PHPStan\Analyser\Scope $scope
+	 *
+	 * @return string[] errors
+	 */
+	public function processNode(Node $node, Scope $scope): array
+	{
+		$functionReflection = $this->broker->getCustomFunction(new Node\Name($node->name), $scope);
+
+		$messages = [];
+
+		foreach ($functionReflection->getParameters() as $parameterReflection) {
+			$message = $this->checkFunctionParameter($functionReflection, $parameterReflection);
+			if ($message === null) {
+				continue;
+			}
+
+			$messages[] = $message;
+		}
+
+		return $messages;
+	}
+
+	private function checkFunctionParameter(FunctionReflection $functionReflection, ParameterReflection $parameterReflection): ?string
+	{
+		$parameterType = $parameterReflection->getType();
+
+		if ($parameterType instanceof MixedType && !$parameterType->isExplicitMixed()) {
+			return sprintf(
+				'Function %s() has parameter $%s with no typehint specified.',
+				$functionReflection->getName(),
+				$parameterReflection->getName()
+			);
+		}
+
+		return null;
+	}
+
+}

Diff for: tests/Rules/Functions/MissingFunctionParameterTypehintRuleTest.php

@@ -0,0 +1,33 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Functions;
+
+class MissingFunctionParameterTypehintRuleTest extends \PHPStan\Testing\RuleTestCase
+{
+
+	protected function getRule(): \PHPStan\Rules\Rule
+	{
+		$rule = new MissingFunctionParameterTypehintRule($this->createBroker([], []));
+
+		return $rule;
+	}
+
+	public function testRule(): void
+	{
+		$this->analyse([__DIR__ . '/data/missing-function-parameter-typehint.php'], [
+			[
+				'Function globalFunction() has parameter $b with no typehint specified',
+				9,
+			],
+			[
+				'Function globalFunction() has parameter $c with no typehint specified',
+				9,
+			],
+			[
+				'Function MissingFunctionParameterTypehint\namespacedFunction() has parameter $d with no typehint specified',
+				24,
+			],
+		]);
+	}
+
+}

Diff for: tests/Rules/Functions/data/missing-function-parameter-typehint.php

@@ -0,0 +1,27 @@
+<?php
+
+namespace
+{
+	/**
+	 * @param int $a
+	 * @param $b
+	 */
+	function globalFunction($a, $b, $c): bool
+	{
+		$closure = function($a, $b, $c) {
+
+		};
+
+		return false;
+	}
+}
+
+namespace MissingFunctionParameterTypehint
+{
+	/**
+	 * @param $d
+	 */
+	function namespacedFunction($d, bool $e): int {
+		return 9;
+	};
+}