Disable PrivateServiceRule when the class implements ServiceSubscriberInterface

Author: iamluc

Diff for: src/Rules/Symfony/ContainerInterfacePrivateServiceRule.php

@@ -42,11 +42,17 @@ public function processNode(Node $node, Scope $scope): array
 		}
 
 		$argType = $scope->getType($node->var);
+
+		$isTestContainerType = (new ObjectType('Symfony\Bundle\FrameworkBundle\Test\TestContainer'))->isSuperTypeOf($argType);
+		$isServiceSubscriber = (new ObjectType('Symfony\Component\DependencyInjection\ServiceSubscriberInterface'))->isSuperTypeOf($argType);
+		if ($isTestContainerType->yes() || $isServiceSubscriber->yes()) {
+			return [];
+		}
+
 		$isControllerType = (new ObjectType('Symfony\Bundle\FrameworkBundle\Controller\Controller'))->isSuperTypeOf($argType);
 		$isAbstractControllerType = (new ObjectType('Symfony\Bundle\FrameworkBundle\Controller\AbstractController'))->isSuperTypeOf($argType);
 		$isContainerType = (new ObjectType('Symfony\Component\DependencyInjection\ContainerInterface'))->isSuperTypeOf($argType);
-		$isTestContainerType = (new ObjectType('Symfony\Bundle\FrameworkBundle\Test\TestContainer'))->isSuperTypeOf($argType);
-		if ($isTestContainerType->yes() || (!$isControllerType->yes() && !$isAbstractControllerType->yes() && !$isContainerType->yes())) {
+		if (!$isControllerType->yes() && !$isAbstractControllerType->yes() && !$isContainerType->yes()) {
 			return [];
 		}
 

Diff for: tests/Rules/Symfony/ContainerInterfacePrivateServiceRuleTest.php

@@ -29,4 +29,18 @@ public function testGetPrivateService(): void
 		);
 	}
 
+	public function testGetPrivateServiceInServiceSubscriber(): void
+	{
+		if (!interface_exists('Symfony\\Component\\DependencyInjection\\ServiceSubscriberInterface')) {
+			self::markTestSkipped('The test needs Symfony\Component\DependencyInjection\ServiceSubscriberInterface class.');
+		}
+
+		$this->analyse(
+			[
+				__DIR__ . '/ExampleServiceSubscriber.php',
+			],
+			[]
+		);
+	}
+
 }

Diff for: tests/Rules/Symfony/ExampleServiceSubscriber.php

@@ -0,0 +1,24 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Symfony;
+
+use Symfony\Bundle\FrameworkBundle\Controller\Controller;
+use Symfony\Component\DependencyInjection\ServiceSubscriberInterface;
+
+final class ExampleServiceSubscriber extends Controller implements ServiceSubscriberInterface
+{
+
+	public function privateService(): void
+	{
+		$this->get('private');
+	}
+
+	/**
+	 * @return string[]
+	 */
+	public static function getSubscribedServices(): array
+	{
+		return [];
+	}
+
+}