List shapes

[zonuexe]

Feature request

List shapes is a variant of array shapes introduced in Psalm 5 that only support implicit and integer-indexed keys.

list{string, int}
list{0: string, 1: int}
list{0: string, 1?: int}

The first step is to just parse list{} as an alias for array{} for interoperability with Psalm.

Did PHPStan help you today? Did it make you happy in any way?

This week I am writing an 8-page article to introduce PHPStan at the PHPerKaigi Japanese conference.

[ondrejmirtes]

Hi, I don't really understand the difference between:

list{string, int}
list{0: string, 1: int}
list{0: string, 1?: int}

and

array{string, int}
array{0: string, 1: int}
array{0: string, 1?: int}

Can you please explain where would they behave differently in PHPStan?

[zonuexe]

list{string, int}
list{0: string, 1: int}
list{0: string, 1?: int}

and

array{string, int}
array{0: string, 1: int}
array{0: string, 1?: int}

Those examples match array and list exactly.

---

The following shapes are not allowed in list{}：

list{1: 1, 2: 2, 3: 3} // should be array{1: 1, 2: 2, 3: 3}
list{1, 2, key: 3}  // should be array{0: 1, 1: 2, key: 3}

These patterns can emulate Psalm's behavior by outputting them as the intersection of an array shape and list.

Also, PHPStan does not yet implement sealed array shapes, so proper support requires changes beyond the parser.

• Psalm: https://psalm.dev/r/7d831b64f1
• PHPStan: https://phpstan.org/r/24f3457d-75df-4f27-9c24-57a83db7b257

[ondrejmirtes]

Those examples match array and list exactly.

What do you mean? They're going to behave exactly the same way?

intersection of an array shape and list

Oh yeah, we could do the same thing here. If the ArrayShapeNode kind is list, we can intersect the array shape with AccessoryArrayListType, which will make list{1: 1, 2: 2, 3: 3} error with "unresolvable type".

[ondrejmirtes]

Implemented: phpstan/phpstan-src#2202

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.