Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engines.node suggests support for Node.js >= 0.8, but #80 broke with Node.js v14 and earlier #87

Open
trentm opened this issue Mar 10, 2025 · 1 comment

Comments

@trentm
Copy link

trentm commented Mar 10, 2025

[email protected] broke usage with Node.js v14 and earlier: #80 uses String.prototype.replaceAll, but this isn't supported in Node.js v14 (https://node.green/#ES2021-features--String-prototype-replaceAll).

The engines.node in package.json suggests that Node.js >=0.8 is supported:
https://github.com/pillarjs/finalhandler/blob/v2.1.0/package.json#L33-L35

Of course, ci.yml only tests with Node.js v18 and later.

For my usage, I'm totally if finalhandler v2 only supports Node.js v18 and later. If so, it would be helpful to update engines.node in package.json, or just remove it.

Thanks.

@bjohansebas
Copy link
Contributor

cc: @pillarjs/express-tc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants