Skip to content

Commit 0fe592e

Browse files
authored
fix: replace methods imports everywhere (#130)
1 parent 878b0e0 commit 0fe592e

File tree

5 files changed

+9
-7
lines changed

5 files changed

+9
-7
lines changed

index.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
const isPromise = require('is-promise')
1616
const Layer = require('./lib/layer')
17-
const methods = require('methods')
17+
const { METHODS } = require('node:http')
1818
const mixin = require('utils-merge')
1919
const parseUrl = require('parseurl')
2020
const Route = require('./lib/route')
@@ -26,6 +26,7 @@ const Route = require('./lib/route')
2626

2727
const slice = Array.prototype.slice
2828
const flatten = Array.prototype.flat
29+
const methods = METHODS.map((method) => method.toLowerCase())
2930

3031
/**
3132
* Expose `Router`.

lib/route.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ const { METHODS } = require('node:http')
2222

2323
const slice = Array.prototype.slice
2424
const flatten = Array.prototype.flat
25+
const methods = METHODS.map((method) => method.toLowerCase())
2526

2627
/* istanbul ignore next */
2728
const defer = typeof setImmediate === 'function'
@@ -215,9 +216,6 @@ Route.prototype.all = function all (handler) {
215216
return this
216217
}
217218

218-
219-
const methods = METHODS.map((method) => method.toLowerCase())
220-
221219
methods.forEach(function (method) {
222220
Route.prototype[method] = function (handler) {
223221
const callbacks = flatten.call(slice.call(arguments), Infinity)

test/route.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
const { it, describe } = require('mocha')
22
const Buffer = require('safe-buffer').Buffer
3-
const methods = require('methods')
43
const series = require('run-series')
54
const Router = require('..')
65
const utils = require('./support/utils')
@@ -13,6 +12,7 @@ const shouldHaveBody = utils.shouldHaveBody
1312
const shouldHitHandle = utils.shouldHitHandle
1413
const shouldNotHaveBody = utils.shouldNotHaveBody
1514
const shouldNotHitHandle = utils.shouldNotHitHandle
15+
const methods = utils.methods
1616

1717
const describePromises = global.Promise ? describe : describe.skip
1818

test/router.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
const { it, describe } = require('mocha')
22
const series = require('run-series')
33
const Buffer = require('safe-buffer').Buffer
4-
const methods = require('methods')
54
const Router = require('..')
65
const utils = require('./support/utils')
76

@@ -14,6 +13,7 @@ const shouldHaveBody = utils.shouldHaveBody
1413
const shouldHitHandle = utils.shouldHitHandle
1514
const shouldNotHaveBody = utils.shouldNotHaveBody
1615
const shouldNotHitHandle = utils.shouldNotHitHandle
16+
const methods = utils.methods
1717

1818
const describePromises = global.Promise ? describe : describe.skip
1919

test/support/utils.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,11 @@ const assert = require('assert')
22
const Buffer = require('safe-buffer').Buffer
33
const finalhandler = require('finalhandler')
44
const http = require('http')
5-
const methods = require('methods')
5+
const { METHODS } = require('node:http')
66
const request = require('supertest')
77

8+
const methods = METHODS.map((method) => method.toLowerCase())
9+
810
exports.assert = assert
911
exports.createHitHandle = createHitHandle
1012
exports.createServer = createServer
@@ -14,6 +16,7 @@ exports.shouldHaveBody = shouldHaveBody
1416
exports.shouldNotHaveBody = shouldNotHaveBody
1517
exports.shouldHitHandle = shouldHitHandle
1618
exports.shouldNotHitHandle = shouldNotHitHandle
19+
exports.methods = methods
1720

1821
function createHitHandle (num) {
1922
const name = 'x-fn-' + String(num)

0 commit comments

Comments
 (0)