Skip to content
This repository was archived by the owner on Jun 3, 2024. It is now read-only.

Commit 1b354ae

Browse files
authored
Merge pull request #934 from ivanna-ostrovets/dev
Fix typo in EnhancedTab disabled_className property
2 parents 8f24185 + 41e44e1 commit 1b354ae

File tree

3 files changed

+12
-1
lines changed

3 files changed

+12
-1
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
1717

1818
### Fixed
1919
- [#930](https://github.com/plotly/dash-core-components/pull/930) Fixed a bug [#867](https://github.com/plotly/dash-core-components/issues/867) with `DatePickerRange` that would sometimes shift the allowed dates by one day.
20+
- [#934](https://github.com/plotly/dash-core-components/pull/934) Fixed a bug in `EnhancedTab` component that ignored `disabled_className` property
2021

2122
## [1.15.0] - 2021-01-19
2223
### Fixed

src/components/Tabs.react.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ export default class Tabs extends Component {
218218
value={childProps.value}
219219
disabled={childProps.disabled}
220220
disabled_style={childProps.disabled_style}
221-
disabled_classname={childProps.disabled_className}
221+
disabled_className={childProps.disabled_className}
222222
mobile_breakpoint={this.props.mobile_breakpoint}
223223
vertical={this.props.vertical}
224224
amountOfTabs={amountOfTabs}

tests/integration/tab/test_tabs_with_graphs.py

+10
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,13 @@ def test_graph_does_not_resize_in_tabs(dash_dcc, is_eager):
2424
children=[
2525
dcc.Tab(label="Tab One", value="tab-1-example", id="tab-1"),
2626
dcc.Tab(label="Tab Two", value="tab-2-example", id="tab-2"),
27+
dcc.Tab(
28+
label="Tab Three",
29+
value="tab-3-example",
30+
id="tab-3",
31+
disabled=True,
32+
disabled_className="disabled-tab",
33+
),
2734
],
2835
),
2936
html.Div(id="tabs-content-example"),
@@ -64,6 +71,9 @@ def render_content(tab):
6471
tab_one = dash_dcc.wait_for_element("#tab-1")
6572
tab_two = dash_dcc.wait_for_element("#tab-2")
6673

74+
# wait for disabled tab with custom className
75+
dash_dcc.wait_for_element("#tab-3.disabled-tab")
76+
6777
WebDriverWait(dash_dcc.driver, 10).until(
6878
EC.element_to_be_clickable((By.ID, "tab-2"))
6979
)

0 commit comments

Comments
 (0)