Merge pull request #907 from plotly/dash-1506

use dash loosen-testing-reqs branch and fix linting

Author: alexcjohnson

dash_core_components_base/__init__.py

@@ -19,7 +19,7 @@
           "named \n'dash.py' in your current directory.", file=_sys.stderr)
     _sys.exit(1)
 
-from ._imports_ import *  # noqa: F401, F403
+from ._imports_ import *  # noqa: F401, F403, E402
 from ._imports_ import __all__  # noqa: E402
 
 _current_path = _os.path.dirname(_os.path.abspath(__file__))

dev-requirements.txt

@@ -1,4 +1,4 @@
 pandas
-xlrd
+xlrd<2
 mimesis;python_version>="3.6"
-virtualenv;python_version=="2.7"
+virtualenv;python_version=="2.7"

tests/integration/location/test_location_callback.py

@@ -87,6 +87,7 @@ def update_pathname(n_clicks, current_pathname):
 
     dash_dcc.start_server(app)
 
+    dash_dcc.wait_for_text_to_equal("#test-pathname", "/")
     dash_dcc.percy_snapshot("link -- location")
 
     # Check that link updates pathname

tests/integration/store/test_store_data.py

@@ -120,7 +120,8 @@ def on_ts(ts, data):
 
 
 @pytest.mark.skipif(
-    sys.version_info < (3, 6), reason="tests requires dependency only available in 3.6+",
+    sys.version_info < (3, 6),
+    reason="tests requires dependency only available in 3.6+",
 )
 @pytest.mark.parametrize("storage_type", ("memory", "local", "session"))
 def test_stda003_large_data_size(storage_type, csv_5mb, dash_dcc):

tests/integration/upload/test_upload_different_file_types.py

@@ -1,7 +1,6 @@
 import io
 import base64
 import os
-import time
 import pytest
 import pandas as pd
 
@@ -24,29 +23,26 @@ def load_table(filetype, payload):
     )
 
     return html.Div(
-        [
-            DataTable(
-                data=df.to_dict("records"),
-                columns=[{"id": i} for i in ["city", "country"]],
-            ),
-            html.Hr(),
-            html.Div("Raw Content"),
-            html.Pre(payload, style=pre_style),
-        ]
+        DataTable(
+            data=df.to_dict("records"),
+            columns=[{"id": i} for i in ["city", "country"]],
+        )
     )
 
 
 def load_data_by_type(filetype, contents):
     children = []
     _type, payload = contents.split(",")
     if filetype in {"csv", "xlsx", "xls"}:
-        return load_table(filetype, payload)
+        children = [load_table(filetype, payload)]
     elif filetype in {"png", "svg"}:
         children = [html.Img(src=contents)]
 
-    children.extend(
-        (html.Hr(), html.Div("Raw Content"), html.Pre(payload, style=pre_style))
-    )
+    children += [
+        html.Hr(),
+        html.Div("Raw Content", id="raw-title"),
+        html.Pre(payload, style=pre_style),
+    ]
     return html.Div(children)
 
 
@@ -92,5 +88,6 @@ def update_output(contents):
 
     upload_div = dash_dcc.wait_for_element("#upload-div input[type=file]")
     upload_div.send_keys(filepath)
-    time.sleep(0.5)
+
+    dash_dcc.wait_for_text_to_equal("#raw-title", "Raw Content")
     dash_dcc.percy_snapshot(filepath)