Skip to content
This repository was archived by the owner on Jun 3, 2024. It is now read-only.

Commit fdb511f

Browse files
authored
Merge pull request #903 from plotly/import-test
improve dash import test
2 parents 610af0f + bc7eef8 commit fdb511f

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

Diff for: CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22
All notable changes to this project will be documented in this file.
33
This project adheres to [Semantic Versioning](http://semver.org/).
44

5+
## [UNRELEASED]
6+
### Fixed
7+
- [#903](https://github.com/plotly/dash-core-components/pull/903) - part of fixing dash import bug https://github.com/plotly/dash/issues/1143
8+
59
## [1.14.1] - 2020-12-09
610
### Updated
711
- [#898](https://github.com/plotly/dash-core-components/pull/898)

Diff for: dash_core_components_base/__init__.py

+1-9
Original file line numberDiff line numberDiff line change
@@ -14,19 +14,11 @@
1414
__version__ = package['version']
1515

1616
# Module imports trigger a dash.development import, need to check this first
17-
if not hasattr(_dash, 'development'):
17+
if not hasattr(_dash, '__plotly_dash') and not hasattr(_dash, 'development'):
1818
print("Dash was not successfully imported. Make sure you don't have a file "
1919
"named \n'dash.py' in your current directory.", file=_sys.stderr)
2020
_sys.exit(1)
2121

22-
# Must update to dash>=0.23.1 to use this version of dash-core-components
23-
if not hasattr(_dash.development.base_component, '_explicitize_args'):
24-
print("Please update the `dash` module to >= 0.23.1 to use this "
25-
"version of dash_core_components.\n"
26-
"You are using version {:s}".format(_dash.version.__version__),
27-
file=_sys.stderr)
28-
_sys.exit(1)
29-
3022
from ._imports_ import * # noqa: F401, F403
3123
from ._imports_ import __all__ # noqa: E402
3224

0 commit comments

Comments
 (0)