rewrite tests with dash[testing] #118

Author: kinimesi

.circleci/config.yml

@@ -81,28 +81,28 @@ jobs:
                 name: Integration Tests - Usage Apps Rendering
                 command: |
                     . venv/bin/activate
-                    python -m unittest tests.test_usage
+                    pytest --headless tests/test_usage.py
                 when: always
 
             - run:
                 name: Integration Tests - Interactions
                 command: |
                     . venv/bin/activate
-                    python -m unittest tests.test_interactions
+                    pytest --headless tests/test_interactions.py
                 when: always
 
             - run:
                 name: Integration Tests - Callbacks
                 command: |
                     . venv/bin/activate
-                    python -m unittest tests.test_callbacks
+                    pytest --headless tests/test_callbacks.py
                 when: always
 
             - run:
                 name: Capture Percy Snapshots
                 command: |
                     . venv/bin/activate
-                    python -m unittest tests.test_percy_snapshot
+                    pytest --headless tests/test_percy_snapshot.py
                 when: always
 
     "python-3.7":

tests/IntegrationTests.py

@@ -9,7 +9,6 @@ percy
 selenium
 flake8
 pylint
-pytest-dash>=2.1.1
 colour==0.1.5
 biopython>=1.77;python_version>="3.0"
 biopython==1.76;python_version=="2.7"

tests/requirements.txt

@@ -1,29 +1,24 @@
 import os
 import importlib
 
-from .IntegrationTests import IntegrationTests
-from selenium.webdriver.common.by import By
-from selenium.webdriver.support.ui import WebDriverWait
-from selenium.webdriver.support import expected_conditions as EC
 from selenium.webdriver.common.keys import Keys
+from selenium.webdriver.common.by import By
 
 
-class Tests(IntegrationTests):
-    def test_callbacks(self):
+class Tests:
+    def test_callbacks(self, dash_duo):
         app = importlib.import_module('usage-advanced').app
-        self.startServer(app)
 
-        WebDriverWait(self.driver, 20).until(
-            EC.presence_of_element_located((By.ID, "cytoscape"))
-        )
+        dash_duo.start_server(app)
+        dash_duo.wait_for_element_by_id("cytoscape", 20)
 
         def create_input_and_save(css_selector,
                                   dir_name,
                                   options,
                                   prefix=None,
                                   name_map=None,
                                   save=True):
-            elem = self.driver.find_element_by_css_selector(css_selector)
+            elem = dash_duo.find_element(css_selector)
 
             directory_path = os.path.join(
                 os.path.dirname(__file__),
@@ -57,9 +52,7 @@ def create_input_and_save(css_selector,
                     name = name.replace('(', '_').replace(')', '').replace(',', '_')
                     name = name.replace('#', '_hex_').replace(' ', '')
 
-                    WebDriverWait(self.driver, 20).until(
-                        EC.presence_of_element_located((By.ID, "cytoscape"))
-                    )
+                    dash_duo.wait_for_element_by_id("cytoscape", 20)
 
                     path = os.path.join(
                         os.path.dirname(__file__),
@@ -68,17 +61,15 @@ def create_input_and_save(css_selector,
                         name + '.png'
                     )
 
-                    self.driver.save_screenshot(path)
+                    dash_duo.driver.save_screenshot(path)
 
         def click_button_and_save(name_to_xpaths, dir_name, save=True):
             for name, xpath in name_to_xpaths.items():
-                button = self.driver.find_element(By.XPATH, xpath)
+                button = dash_duo.driver.find_element(By.XPATH, xpath)
                 button.click()
 
                 if save:
-                    WebDriverWait(self.driver, 20).until(
-                        EC.presence_of_element_located((By.ID, "cytoscape"))
-                    )
+                    dash_duo.wait_for_element_by_id("cytoscape", 20)
 
                     path = os.path.join(
                         os.path.dirname(__file__),
@@ -87,7 +78,7 @@ def click_button_and_save(name_to_xpaths, dir_name, save=True):
                         name + '.png'
                     )
 
-                    self.driver.save_screenshot(path)
+                    dash_duo.driver.save_screenshot(path)
 
         create_input_and_save(
             css_selector='input#dropdown-select-element-list',

tests/test_callbacks.py

@@ -23,26 +23,20 @@
 import importlib
 import time
 import json
-import platform
 
-from .IntegrationTests import IntegrationTests
-from selenium.webdriver.common.by import By
-from selenium.webdriver.support.ui import WebDriverWait
-from selenium.webdriver.support import expected_conditions as EC
 from selenium.webdriver.common.action_chains import ActionChains
 
 
-class Tests(IntegrationTests):
-    @classmethod
-    def setUpClass(cls):
-        super(Tests, cls).setUpClass()
-
+class Tests:
+    def create_app(self, dash_duo):
         # Initialize the apps
         app = importlib.import_module('usage-events').app
-        cls.startServer(cls, app)
-        WebDriverWait(cls.driver, 20).until(EC.presence_of_element_located((By.ID, "cytoscape")))
-        cls.actions = ActionChains(cls.driver)
-        cls.init_pos = {
+
+        dash_duo.start_server(app)
+        dash_duo.wait_for_element_by_id("cytoscape", 20)
+
+        self.actions = ActionChains(dash_duo.driver)
+        self.init_pos = {
             'Node 1': (59, 182),
             'Node 2': (222, 345),
             'Node 3': (168, 283 - 20),
@@ -51,21 +45,6 @@ def setUpClass(cls):
             'Node 6': (168, 283)
         }
 
-    @classmethod
-    def tearDownClass(cls):
-        super(Tests, cls).tearDownClass()
-
-        time.sleep(3)
-        if platform.system() == 'Windows':
-            cls.driver.get('http://localhost:8050/stop')
-        else:
-            cls.server_process.terminate()
-        time.sleep(3)
-        cls.driver.quit()
-
-    def tearDown(self):
-        pass
-
     def save_screenshot(self, dir_name, name):
         directory_path = os.path.join(
             os.path.dirname(__file__),
@@ -77,7 +56,7 @@ def save_screenshot(self, dir_name, name):
         if not os.path.exists(directory_path):
             os.makedirs(directory_path)
 
-        self.driver.save_screenshot(os.path.join(
+        self.dash_duo.driver.save_screenshot(os.path.join(
             os.path.dirname(__file__),
             'screenshots',
             dir_name,
@@ -96,7 +75,7 @@ def perform_dragging(self, x, y, delta_x, delta_y, elem, actions, dir_name='inte
         """
         actions.reset_actions()
         actions.move_to_element_with_offset(
-            self.driver.find_element_by_tag_name('body'), x, y
+            self.dash_duo.driver.find_element_by_tag_name('body'), x, y
         )
         actions.drag_and_drop_by_offset(source=None, xoffset=delta_x, yoffset=delta_y)
         actions.click()
@@ -127,7 +106,7 @@ def perform_clicking(self, x, y, elem, actions, dir_name='interactions'):
         """
         actions.reset_actions()
         actions.move_to_element_with_offset(
-            self.driver.find_element_by_tag_name('body'), x, y
+            self.dash_duo.driver.find_element_by_tag_name('body'), x, y
         )
         actions.click()
         actions.perform()
@@ -142,7 +121,7 @@ def perform_clicking(self, x, y, elem, actions, dir_name='interactions'):
     def perform_mouseover(self, x, y, elem, actions, dir_name='interactions'):
         actions.reset_actions()
         actions.move_to_element_with_offset(
-            self.driver.find_element_by_tag_name('body'), x - 50, y
+            self.dash_duo.driver.find_element_by_tag_name('body'), x - 50, y
         )
         actions.move_by_offset(50, 0)
         actions.perform()
@@ -154,7 +133,10 @@ def perform_mouseover(self, x, y, elem, actions, dir_name='interactions'):
 
         return mouseover_label
 
-    def test_dragging(self):
+    def test_dragging(self, dash_duo):
+        self.dash_duo = dash_duo
+        self.create_app(dash_duo)
+
         drag_error = "Unable to drag Cytoscape nodes properly"
 
         # View module docstring for more information about initial positions
@@ -164,7 +146,7 @@ def test_dragging(self):
         actions = self.actions
 
         # Select the JSON output element
-        elem_tap = self.driver.find_element_by_css_selector('pre#tap-node-json-output')
+        elem_tap = dash_duo.find_element('pre#tap-node-json-output')
 
         # Test dragging the nodes around
         offset_x, offset_y = self.perform_dragging(init_x, init_y, 0, 0, elem_tap, actions)
@@ -178,33 +160,38 @@ def test_dragging(self):
         assert self.perform_dragging(init_x+150, init_y+150, -150, -150, elem_tap, actions) == \
             (-150, -150), drag_error
 
-    def test_clicking(self):
+    def test_clicking(self, dash_duo):
+        self.dash_duo = dash_duo
+        self.create_app(dash_duo)
+
         click_error = "Unable to click Cytoscape nodes properly"
         actions = self.actions
 
         # Select the JSON output element
-        elem_tap = self.driver.find_element_by_css_selector('pre#tap-node-json-output')
+        elem_tap = dash_duo.find_element('pre#tap-node-json-output')
 
         init_pos = self.init_pos
         # Test clicking the nodes
         for i in range(1, 7):
             label = 'Node {}'.format(i)
             assert self.perform_clicking(*init_pos[label], elem_tap, actions) == label, click_error
 
-    def test_mouseover(self):
+    def test_mouseover(self, dash_duo):
+        self.dash_duo = dash_duo
+        self.create_app(dash_duo)
+
         init_pos = self.init_pos
         mouseover_error = "Unable to mouseover Cytoscape nodes properly"
         actions = self.actions
 
         # Open the Mouseover JSON tab
         actions.move_to_element(
-            self.driver.find_element_by_css_selector('#tabs > div:nth-child(3)'))
+            dash_duo.find_element('#tabs > div:nth-child(3)'))
         actions.click().perform()
         time.sleep(1)
 
         # Select the JSON output element
-        elem_mouseover = self.driver.find_element_by_css_selector(
-            'pre#mouseover-node-data-json-output')
+        elem_mouseover = dash_duo.find_element('pre#mouseover-node-data-json-output')
 
         # Test hovering the nodes
         for i in range(1, 7):