externalize prop-types

Marc-André Rivet · Marc-André Rivet · commit dfcc74e00e46 · 2019-06-11T13:26:59.000-04:00
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -29,8 +29,8 @@ jobs:
       - run:
           name: Install dependencies (dash)
           command: |
-              git clone --depth 1 git@github.com:plotly/dash.git dash-main
-              git clone --depth 1 git@github.com:plotly/dash-core-components.git
+              git clone --depth 1  -b prop-types-dev git@github.com:plotly/dash.git dash-main
+              git clone --depth 1  -b prop-types-dev git@github.com:plotly/dash-core-components.git
               git clone --depth 1 git@github.com:plotly/dash-table.git
               . venv/bin/activate
               pip install -e ./dash-main --quiet
diff --git a/webpack.config.js b/webpack.config.js
@@ -38,6 +38,7 @@ module.exports = (env, argv) => {
         react: 'React',
         'react-dom': 'ReactDOM',
         'plotly.js': 'Plotly',
+        'prop-types': 'PropTypes'
     });
 
     return {

-Original file line number
+Diff line change
       - run:
           name: Install dependencies (dash)
           command: |
 -              git clone --depth 1 [email protected]:plotly/dash.git dash-main
 -              git clone --depth 1 [email protected]:plotly/dash-core-components.git
 +              git clone --depth 1  -b prop-types-dev [email protected]:plotly/dash.git dash-main
 +              git clone --depth 1  -b prop-types-dev [email protected]:plotly/dash-core-components.git
               git clone --depth 1 [email protected]:plotly/dash-table.git
               . venv/bin/activate
               pip install -e ./dash-main --quiet