Skip to content
This repository was archived by the owner on Jun 4, 2024. It is now read-only.

TableTooltip has shouldComponentUpdate but is a React.PureComponent #561

Closed
LuAPi opened this issue Aug 28, 2019 · 0 comments · Fixed by #624
Closed

TableTooltip has shouldComponentUpdate but is a React.PureComponent #561

LuAPi opened this issue Aug 28, 2019 · 0 comments · Fixed by #624
Assignees
Labels
dash-type-maintenance Technical debt, dependency management, additional testing, etc. size: 0.2
Milestone

Comments

@LuAPi
Copy link

LuAPi commented Aug 28, 2019

I've just started getting warnings like

Warning: t has a method called shouldComponentUpdate(). shouldComponentUpdate should not be used when extending React.PureComponent. Please extend React.Component if shouldComponentUpdate is used.
warningWithoutStack	@	[email protected]?….1&m=1566991803:500
checkClassInstance	@	[email protected]?…&m=1566991803:11401
mountClassInstance	@	[email protected]?…&m=1566991803:11598
.....

I based on the warning message think I tracked it down to shouldComponentUpdate being defined in:
https://github.com/plotly/dash-table/blob/master/src/dash-table/components/ControlledTable/fragments/TableTooltip.tsx#L26

Given that that code is 7 months old and I've not seen that warning before I'm not sure if it's something I've done to upset the system or if I got a newer version of something when I rebuilt my app's container. Since I'm not sure I thought I should open an issue rather than make a PR to change the React.PureComponent to a React.Component like the warning says to.

Edit:
After reporting another issue I noticed that when rebuilding my docker container I updated to the new dash 1.2.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dash-type-maintenance Technical debt, dependency management, additional testing, etc. size: 0.2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants