Skip to content

Commit 1122fd4

Browse files
authored
Merge pull request #1434 from plotly/julia-noncore-fix
julia non-core components: require Dash 0.1.3
2 parents e6f133c + 40bef9c commit 1122fd4

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

Diff for: CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22
All notable changes to `dash` will be documented in this file.
33
This project adheres to [Semantic Versioning](https://semver.org/).
44

5+
## [UNRELEASED]
6+
### Fixed
7+
- [#1434](https://github.com/plotly/dash/pull/1434) Fix [#1432](https://github.com/plotly/dash/issues/1432) for Julia to import non-core component packages without possible errors.
8+
59
## [1.16.3] - 2020-10-07
610
### Fixed
711
- [#1426](https://github.com/plotly/dash/pull/1426) Fix a regression caused by `flask-compress==1.6.0` causing performance degradation on server requests

Diff for: dash/development/_jl_components_generation.py

+10-2
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,14 @@
8484
8585
[compat]
8686
julia = "1.2"
87-
{base_package} = "0.1"
87+
{base_package} = "{base_version}"
8888
"""
8989

90+
jl_base_version = {
91+
"Dash": "0.1.3",
92+
"DashBase": "0.1",
93+
}
94+
9095
jl_component_include_string = 'include("{name}.jl")'
9196

9297
jl_resource_tuple_string = """DashBase.Resource(
@@ -417,12 +422,15 @@ def generate_toml_file(project_shortname, pkg_data):
417422
'authors = ["{}"]\n'.format(package_author) if package_author else ""
418423
)
419424

425+
base_package = base_package_name(project_shortname)
426+
420427
toml_string = jl_projecttoml_string.format(
421428
package_name=package_name,
422429
package_uuid=package_uuid,
423430
version=project_ver,
424431
authors=authors_string,
425-
base_package=base_package_name(project_shortname),
432+
base_package=base_package,
433+
base_version=jl_base_version[base_package],
426434
dash_uuid=base_package_uid(project_shortname),
427435
)
428436
file_path = "Project.toml"

0 commit comments

Comments
 (0)