Skip to content

Commit 2c9a3c8

Browse files
committed
include linting in test.sh
1 parent 2f5e276 commit 2c9a3c8

File tree

3 files changed

+8
-11
lines changed

3 files changed

+8
-11
lines changed

.circleci/config.yml

-9
Original file line numberDiff line numberDiff line change
@@ -35,15 +35,6 @@ jobs:
3535
paths:
3636
- "venv"
3737

38-
- run:
39-
name: Run lint
40-
command: |
41-
. venv/bin/activate
42-
pylint dash setup.py --rcfile=$PYLINTRC
43-
pylint tests -d all -e C0410,C0411,C0412,C0413,W0109
44-
flake8 dash setup.py
45-
flake8 --ignore=E123,E126,E501,E722,E731,F401,F841,W503,W504 --exclude=metadata_test.py tests
46-
4738
- run:
4839
name: Run tests
4940
command: |

dash/dash.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,13 @@
1515

1616
from functools import wraps
1717

18-
import plotly
19-
import dash_renderer
2018
import flask
2119
from flask import Flask, Response
2220
from flask_compress import Compress
2321

22+
import plotly
23+
import dash_renderer
24+
2425
from .dependencies import Input, Output, State
2526
from .resources import Scripts, Css
2627
from .development.base_component import Component

test.sh

+5
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,11 @@ python -m unittest tests.test_integration || EXIT_STATE=$?
66
python -m unittest tests.test_resources || EXIT_STATE=$?
77
python -m unittest tests.test_configs || EXIT_STATE=$?
88

9+
pylint dash setup.py --rcfile=$PYLINTRC || EXIT_STATE=$?
10+
pylint tests -d all -e C0410,C0411,C0412,C0413,W0109 || EXIT_STATE=$?
11+
flake8 dash setup.py || EXIT_STATE=$?
12+
flake8 --ignore=E123,E126,E501,E722,E731,F401,F841,W503,W504 --exclude=metadata_test.py tests || EXIT_STATE=$?
13+
914
if [ $EXIT_STATE -ne 0 ]; then
1015
echo "One or more tests failed"
1116
else

0 commit comments

Comments
 (0)