Skip to content

Commit 3ab16b3

Browse files
committed
downgrade black for py36
because otherwise you can't install redis so don't do black linting on py36
1 parent c3c84b9 commit 3ab16b3

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

components/dash-core-components/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"private::format.black": "black dash_core_components_base/ tests/ setup.py",
1616
"private::format.eslint": "eslint src --fix",
1717
"private::format.prettier": "prettier --config .prettierrc --write src/**/*.js",
18-
"private::lint.black": "black --check dash_core_components_base/ tests/ setup.py",
18+
"private::lint.black": "if [[ ${PYVERSION:-python39} != python36 ]]; then black --check dash_core_components_base/ tests/ setup.py; fi",
1919
"private::lint.eslint": "eslint src",
2020
"private::lint.flake8": "flake8 --exclude=dash_core_components,node_modules,venv",
2121
"private::lint.prettier": "prettier --config .prettierrc src/**/*.js --list-different",

components/dash-table/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"private::format.black": "black dash_table_base tests",
2424
"private::lint.ts": "eslint ./src ./tests",
2525
"private::lint.flake": "flake8 dash_table_base tests",
26-
"private::lint.black": "black --check dash_table_base tests",
26+
"private::lint.black": "if [[ ${PYVERSION:-python39} != python36 ]]; then black --check dash_table_base tests; fi",
2727
"private::lint.prettier": "prettier --config .prettierrc \"{src,tests,demo}/**/*.{js,ts,tsx}\" --list-different",
2828
"private::test.python": "python -m unittest tests/unit/format_test.py",
2929
"private::test.unit": "karma start karma.conf.js --single-run",

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"private::initialize.renderer": "cd dash/dash-renderer && npm ci",
88
"private::build.components": "python dash/development/update_components.py 'all'",
99
"private::build.renderer": "cd dash/dash-renderer && renderer build",
10-
"private::lint.black": "black dash tests --exclude metadata_test.py --check",
10+
"private::lint.black": "if [[ ${PYVERSION:-python39} != python36 ]]; then black dash tests --exclude metadata_test.py --check; fi",
1111
"private::lint.flake8": "flake8 --exclude=metadata_test.py dash tests",
1212
"private::lint.pylint-dash": "PYLINTRC=${PYLINTRC:=.pylintrc39} && pylint dash setup.py --rcfile=$PYLINTRC",
1313
"private::lint.pylint-tests": "PYLINTRC=${PYLINTRC:=.pylintrc39} && pylint tests/unit tests/integration -d all --rcfile=$PYLINTRC",

requires-ci.txt

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# Dependencies used by CI on github.com/plotly/dash
2-
black==22.3.0
2+
black==22.3.0;python_version>="3.7"
3+
black==21.6b0;python_version<"3.7"
34
dash-flow-example==0.0.5
45
dash-dangerously-set-inner-html
56
flake8==3.9.2

0 commit comments

Comments
 (0)