Skip to content

Commit 5b3745d

Browse files
committed
IE11 compatibility for renderer, dcc, table
need to downgrade some fontawesome packages I *JUST* upgraded
1 parent 5268595 commit 5b3745d

File tree

8 files changed

+96
-75
lines changed

8 files changed

+96
-75
lines changed

Diff for: components/dash-core-components/package-lock.json

+33-33
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: components/dash-core-components/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@
3636
"maintainer": "Alex Johnson <[email protected]>",
3737
"license": "MIT",
3838
"dependencies": {
39-
"@fortawesome/fontawesome-svg-core": "^1.3.0",
40-
"@fortawesome/free-regular-svg-icons": "^6.0.0",
41-
"@fortawesome/free-solid-svg-icons": "^6.0.0",
39+
"@fortawesome/fontawesome-svg-core": "1.2.36",
40+
"@fortawesome/free-regular-svg-icons": "^5.15.4",
41+
"@fortawesome/free-solid-svg-icons": "^5.15.4",
4242
"@fortawesome/react-fontawesome": "^0.1.17",
4343
"base64-js": "^1.5.1",
4444
"color": "^4.2.1",

Diff for: components/dash-core-components/src/fragments/Graph.react.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import React, {Component} from 'react';
2-
import ResizeDetector from 'react-resize-detector';
2+
// /build/withPolyfill for IE11 support - https://github.com/maslianok/react-resize-detector/issues/144
3+
import ResizeDetector from 'react-resize-detector/build/withPolyfill';
34
import {
45
equals,
56
filter,

Diff for: components/dash-table/package-lock.json

+33-33
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: components/dash-table/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,9 @@
4848
"@babel/polyfill": "^7.12.1",
4949
"@babel/preset-env": "^7.16.11",
5050
"@babel/preset-react": "^7.16.7",
51-
"@fortawesome/fontawesome-svg-core": "^1.3.0",
52-
"@fortawesome/free-regular-svg-icons": "^6.0.0",
53-
"@fortawesome/free-solid-svg-icons": "^6.0.0",
51+
"@fortawesome/fontawesome-svg-core": "1.2.36",
52+
"@fortawesome/free-regular-svg-icons": "^5.15.4",
53+
"@fortawesome/free-solid-svg-icons": "^5.15.4",
5454
"@fortawesome/react-fontawesome": "^0.1.17",
5555
"@percy/storybook": "^3.3.1",
5656
"@plotly/dash-component-plugins": "^1.2.2",

Diff for: components/dash-table/src/dash-table/components/Table/style.ts

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
// NOTE: need to pin fontawesome-svg-core to <1.3 and free-*-svg-icons to <6
2+
// or we break IE11
13
import {library} from '@fortawesome/fontawesome-svg-core';
24
import {faEyeSlash, faTrashAlt} from '@fortawesome/free-regular-svg-icons';
35
import {

Diff for: dash/dash-renderer/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"build:dev": "webpack",
1414
"build:local": "renderer build local",
1515
"build": "renderer build && npm run prepublishOnly",
16-
"postbuild": "es-check es5 ../deps/*.js",
16+
"postbuild": "es-check es5 ../deps/*.js build/*.js",
1717
"test": "karma start karma.conf.js --single-run",
1818
"format": "run-s private::format.*",
1919
"lint": "run-s private::lint.*"

Diff for: dash/dash-renderer/webpack.base.config.js

+19-1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,20 @@ const defaults = {
1414
loader: 'babel-loader',
1515
},
1616
},
17+
{
18+
test: /\.jsx?$/,
19+
include: /node_modules[\\\/](cytoscape-fcose)[\\\/]/,
20+
use: {
21+
loader: 'babel-loader',
22+
options: {
23+
babelrc: false,
24+
configFile: false,
25+
presets: [
26+
'@babel/preset-env'
27+
]
28+
}
29+
}
30+
},
1731
{
1832
test: /\.ts(x?)$/,
1933
exclude: /node_modules/,
@@ -56,7 +70,11 @@ const rendererOptions = {
5670
module.exports = options => [
5771
R.mergeAll([
5872
options,
59-
rendererOptions
73+
rendererOptions,
74+
{
75+
// with default eval sourcemap we can't es-check the dev bundle
76+
devtool: 'inline-source-map'
77+
}
6078
]),
6179
R.mergeAll([
6280
options,

0 commit comments

Comments
 (0)