Skip to content

Commit 61b40be

Browse files
authored
Merge pull request #2146 from plotly/no-console
No console log
2 parents aee0979 + 7a0feb0 commit 61b40be

File tree

4 files changed

+6
-1
lines changed

4 files changed

+6
-1
lines changed

Diff for: CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22
All notable changes to `dash` will be documented in this file.
33
This project adheres to [Semantic Versioning](https://semver.org/).
44

5+
## [UNRELEASED]
6+
7+
- [#2146](https://github.com/plotly/dash/pull/2146) Remove leftover debug console.log statement.
8+
59
## [2.6.0] - 2022-07-14
610

711
### Added

Diff for: dash/dash-renderer/.eslintrc.js

+1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ module.exports = {
2828
'prefer-arrow-callback': 2,
2929
'quote-props': [2, 'as-needed'],
3030
'quotes': [2, 'single', { 'avoidEscape': true }],
31+
'no-console': 2,
3132
'@typescript-eslint/ban-types': 0,
3233
'@typescript-eslint/explicit-module-boundary-types': 0,
3334
'@typescript-eslint/array-type': 0,

Diff for: dash/dash-renderer/src/actions/api.js

+1
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ export default function apiThunk(endpoint, method, store, id, body) {
6060
// fetch rejection - this means the request didn't return,
6161
// we don't get here from 400/500 errors, only network
6262
// errors or unresponsive servers.
63+
// eslint-disable-next-line no-console
6364
console.log('fetch error', res);
6465
setConnectionStatus(false);
6566
return;

Diff for: dash/dash-renderer/src/actions/callbacks.ts

-1
Original file line numberDiff line numberDiff line change
@@ -650,7 +650,6 @@ export function executeCallback(
650650
let lastError: any;
651651

652652
const additionalArgs: [string, string, boolean?][] = [];
653-
console.log(cb.callback.output, getState().callbackJobs);
654653
values(getState().callbackJobs).forEach(
655654
(job: CallbackJobPayload) => {
656655
if (cb.callback.output === job.output) {

0 commit comments

Comments
 (0)