Skip to content

Commit 6c0bd06

Browse files
support chrome driver.name.lower() being chrome-headless-shell
use passed in browser to distinguish browser type update smoke test to use .startswith()
1 parent 4e37267 commit 6c0bd06

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

Diff for: dash/testing/browser.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -603,7 +603,7 @@ def get_logs(self):
603603
604604
Chrome only
605605
"""
606-
if self.driver.name.lower() == "chrome":
606+
if self._browser == "chrome":
607607
return [
608608
entry
609609
for entry in self.driver.get_log("browser")
@@ -614,7 +614,7 @@ def get_logs(self):
614614

615615
def reset_log_timestamp(self):
616616
"""reset_log_timestamp only work with chrome webdriver."""
617-
if self.driver.name.lower() == "chrome":
617+
if self._browser == "chrome":
618618
entries = self.driver.get_log("browser")
619619
if entries:
620620
self._last_ts = entries[-1]["timestamp"]

Diff for: tests/unit/test_browser.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ def test_browser_smoke(browser_type, tmpdir):
1515
download_path=tmpdir.mkdir("download").strpath,
1616
percy_finalize=True,
1717
)
18-
assert browser.driver.name == browser_type.lower()
18+
assert browser.driver.name.startswith(browser_type.lower())
1919

2020

2121
def test_browser_use_remote_webdriver(tmpdir):

0 commit comments

Comments
 (0)