Skip to content

Commit 74a432e

Browse files
committed
Merge pull request #38 from plotly/dropdown-cell-height
dropdown alignment with td alignment
1 parent 45602ad commit 74a432e

File tree

2 files changed

+18
-1
lines changed

2 files changed

+18
-1
lines changed

packages/dash-table/src/lib/components/Dropdown.css

+12-1
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,21 @@
22
.dash-spreadsheet .Select-control {
33
border: none;
44
cursor: pointer;
5-
height: 26px;
5+
height: 30px; /* matches the td height and line-height */
66
border: none;
77
}
88

9+
.dash-spreadsheet .Select-placeholder,
10+
.dash-spreadsheet .Select--single > .Select-control .Select-value {
11+
height: 100%;
12+
line-height: inherit;
13+
}
14+
15+
.dash-spreadsheet .Select.has-value.Select--single > .Select-control .Select-value .Select-value-label,
16+
.dash-spreadsheet .Select.has-value.is-pseudo-focused.Select--single > .Select-control .Select-value .Select-value-label {
17+
color: var(--text-color);
18+
}
19+
920
.dash-spreadsheet .Select:hover,
1021
.dash-spreadsheet .Select-control:hover {
1122
border: none;

packages/dash-table/src/lib/components/Table.css

+6
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,12 @@ tr:hover input :not(.cell--selected) {
113113
box-sizing: border-box;
114114
color: var(--text-color);
115115
background-color: transparent; /* so as to not overlay the box shadow */
116+
117+
/* browser's default text-shadow is `$color 0px 0px 0px;`
118+
* for `input`, which makes it look a little bit heavier than dropdowns
119+
* or bare `td`
120+
*/
121+
text-shadow: none;
116122
}
117123

118124
.dash-spreadsheet input.unfocused {

0 commit comments

Comments
 (0)