Skip to content

Commit 8709143

Browse files
authored
Merge pull request #676 from plotly/add-enable-dev-tools
✨ add dev_tools_ui in config
2 parents 1e67f3a + 791bae0 commit 8709143

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

Diff for: CHANGELOG.md

+8
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
## Unreleased
2+
3+
### Added
4+
5+
- add `dev_tools_ui` in `<script id="_dash-config" type="application/json">`,
6+
so renderer can know if it should enable the UI. [#676](https://github.com/plotly/dash/pull/676)
7+
8+
19
## [0.40.0] - 2019-03-25
210
### Changed
311
- Bumped dash-core-components version from 0.44.0 to [0.45.0](https://github.com/plotly/dash-core-components/blob/master/CHANGELOG.md#0450---2019-03-25)

Diff for: dash/dash.py

+6-2
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,8 @@ def _handle_error(_):
237237
'hot_reload': False,
238238
'hot_reload_interval': 3000,
239239
'hot_reload_watch_interval': 0.5,
240-
'hot_reload_max_retry': 8
240+
'hot_reload_max_retry': 8,
241+
'dev_tools_ui': False,
241242
})
242243

243244
# add a handler for components suites errors to return 404
@@ -328,7 +329,8 @@ def serve_layout(self):
328329
def _config(self):
329330
config = {
330331
'url_base_pathname': self.url_base_pathname,
331-
'requests_pathname_prefix': self.config['requests_pathname_prefix']
332+
'requests_pathname_prefix': self.config.requests_pathname_prefix,
333+
'dev_tools_ui': self._dev_tools.dev_tools_ui,
332334
}
333335
if self._dev_tools.hot_reload:
334336
config['hot_reload'] = {
@@ -1227,6 +1229,8 @@ def enable_dev_tools(self,
12271229
debug = debug or _configs.get_config('debug', None, env, debug,
12281230
is_bool=True)
12291231

1232+
self._dev_tools.dev_tools_ui = debug
1233+
12301234
self._dev_tools['serve_dev_bundles'] = _configs.get_config(
12311235
'serve_dev_bundles', dev_tools_serve_dev_bundles, env,
12321236
default=debug,

0 commit comments

Comments
 (0)