Linting updates

Author: HammadTheOne

.flake8

@@ -2,4 +2,4 @@
 ignore = C901, E203, E266, E501, E731, W503
 select = B,C,E,F,W,T4
 per-file-ignores =
-    tests/*: E722, F811
+    tests/*: E722, F811

.pylintrc

@@ -13,6 +13,12 @@ ignore=CVS
 # regex matches against base names, not paths.
 ignore-patterns=
 
+# Add files or directories matching the regex patterns to the ignore-list.
+# The regex matches against paths.
+ignore-paths=^dash/dcc/.*$,
+             ^dash/html/.*$,
+             ^dash/dash_table/.*$
+
 # Python code to execute, usually for sys.path manipulation such as
 # pygtk.require().
 #init-hook=

.pylintrc39

@@ -13,6 +13,12 @@ ignore=CVS
 # regex matches against base names, not paths.
 ignore-patterns=
 
+# Add files or directories matching the regex patterns to the ignore-list.
+# The regex matches against paths.
+ignore-paths=^dash/dcc/.*$,
+             ^dash/html/.*$,
+             ^dash/dash_table/.*$
+
 # Python code to execute, usually for sys.path manipulation such as
 # pygtk.require().
 #init-hook=

dash/_utils.py

@@ -10,7 +10,7 @@
 import io
 import json
 from functools import wraps
-import future.utils as utils
+from future import utils
 from . import exceptions
 
 logger = logging.getLogger()
@@ -217,16 +217,16 @@ def inputs_to_vals(inputs):
 
 def run_command_with_process(cmd):
     is_win = sys.platform == "win32"
-    proc = subprocess.Popen(shlex.split(cmd, posix=is_win), shell=is_win)
-    proc.wait()
-    if proc.poll() is None:
-        logger.warning("🚨 trying to terminate subprocess in safe way")
-        try:
-            proc.communicate()
-        except Exception:  # pylint: disable=broad-except
-            logger.exception("🚨 first try communicate failed")
-            proc.kill()
-            proc.communicate()
+    with subprocess.Popen(shlex.split(cmd, posix=is_win), shell=is_win) as proc:
+        proc.wait()
+        if proc.poll() is None:
+            logger.warning("🚨 trying to terminate subprocess in safe way")
+            try:
+                proc.communicate()
+            except Exception:  # pylint: disable=broad-except
+                logger.exception("🚨 first try communicate failed")
+                proc.kill()
+                proc.communicate()
 
 
 def compute_md5(path):

dash/dash.py

@@ -583,7 +583,7 @@ def _collect_and_register_resources(self, resources):
         # add the version number of the package as a query parameter
         # for cache busting
         def _relative_url_path(relative_package_path="", namespace=""):
-            if any(x in relative_package_path for x in ["dcc" "html", "dash_table"]):
+            if any(x in relative_package_path for x in ["dcc", "html", "dash_table"]):
                 relative_package_path = relative_package_path.replace("dash.", "")
                 version = importlib.import_module(
                     "{}.{}".format(namespace, os.path.split(relative_package_path)[0])

dash/development/base_component.py

@@ -83,7 +83,7 @@ def __init__(self, **kwargs):
         for k, v in list(kwargs.items()):
             # pylint: disable=no-member
             k_in_propnames = k in self._prop_names
-            k_in_wildcards = any(
+            k_in_wildcards = any(  # pylint: disable=use-a-generator
                 [k.startswith(w) for w in self._valid_wildcard_attributes]
             )
             # e.g. "The dash_core_components.Dropdown component (version 1.6.0)

dash/development/component_generator.py

@@ -72,11 +72,11 @@ def generate_components(
         "package.json", os.path.join(project_shortname, package_info_filename)
     )
 
-    proc = subprocess.Popen(
+    with subprocess.Popen(
         cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=is_windows
-    )
-    out, err = proc.communicate()
-    status = proc.poll()
+    ) as proc:
+        out, err = proc.communicate()
+        status = proc.poll()
 
     if err:
         print(err.decode(), file=sys.stderr)

dash/development/update_components.py

@@ -28,11 +28,11 @@ def booststrap_components(components_source):
         "npx lerna bootstrap --scope *@({})*".format(source_glob), posix=not is_windows,
     )
 
-    proc = subprocess.Popen(
+    with subprocess.Popen(
         cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=is_windows
-    )
-    out, err = proc.communicate()
-    status = proc.poll()
+    ) as proc:
+        out, err = proc.communicate()
+        status = proc.poll()
 
     if err:
         print(err.decode(), file=sys.stderr)
@@ -44,7 +44,7 @@ def booststrap_components(components_source):
             ),
             file=sys.stderr,
         )
-    else:
+    if not out:
         print(
             "Failed bootstrapping the following component packages {} (status={})".format(
                 source_glob, status
@@ -68,11 +68,11 @@ def build_components(components_source):
         posix=not is_windows,
     )
 
-    proc = subprocess.Popen(
+    with subprocess.Popen(
         cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=is_windows
-    )
-    out, err = proc.communicate()
-    status = proc.poll()
+    ) as proc:
+        out, err = proc.communicate()
+        status = proc.poll()
 
     if err:
         print(err.decode(), file=sys.stderr)

dash/testing/application_runners.py

@@ -11,12 +11,12 @@
 import inspect
 
 import runpy
-import future.utils as utils
 import flask
 import requests
 
+from future import utils
 from dash.testing.errors import NoAppFoundError, TestingTimeoutError, ServerCloseError
-import dash.testing.wait as wait
+from dash.testing import wait
 
 
 logger = logging.getLogger(__name__)
@@ -202,7 +202,7 @@ def start(
         logger.debug("start dash process with %s", args)
 
         try:
-            self.proc = subprocess.Popen(
+            self.proc = subprocess.Popen(  # pylint: disable=consider-using-with
                 args, stdout=subprocess.PIPE, stderr=subprocess.PIPE
             )
             # wait until server is able to answer http request
@@ -323,7 +323,7 @@ def start(self, app, start_timeout=2, cwd=None):
         logger.debug("start dash process with %s", args)
 
         try:
-            self.proc = subprocess.Popen(
+            self.proc = subprocess.Popen(  # pylint: disable=consider-using-with
                 args,
                 stdout=subprocess.PIPE,
                 stderr=subprocess.PIPE,
@@ -423,7 +423,7 @@ def start(self, app, start_timeout=30, cwd=None):
         logger.debug("start Dash.jl process with %s", args)
 
         try:
-            self.proc = subprocess.Popen(
+            self.proc = subprocess.Popen(  # pylint: disable=consider-using-with
                 args,
                 stdout=subprocess.PIPE,
                 stderr=subprocess.PIPE,

dash/testing/browser.py

@@ -412,7 +412,7 @@ def get_webdriver(self):
         try:
             return getattr(self, "_get_{}".format(self._browser))()
         except WebDriverException:
-            logger.exception("<<<Webdriver not initialized correctly>>>")
+            return logger.exception("<<<Webdriver not initialized correctly>>>")
 
     def _get_wd_options(self):
         options = (

package.json

@@ -6,7 +6,7 @@
     "private::format.renderer": "cd dash/dash-renderer && npm run format",
     "private::initialize.renderer": "cd dash/dash-renderer && npm ci",
     "private::lint.black": "if [ ${PYLINTRC:-x} != '.pylintrc' ]; then black dash tests --exclude metadata_test.py --check; fi",
-    "private::lint.flake8": "flake8 --exclude=metadata_test.py dash tests",
+    "private::lint.flake8": "flake8 --exclude=metadata_test.py,dash/html/I.py dash tests",
     "private::lint.pylint-dash": "PYLINTRC=${PYLINTRC:=.pylintrc39} && pylint dash setup.py --rcfile=$PYLINTRC",
     "private::lint.pylint-tests": "PYLINTRC=${PYLINTRC:=.pylintrc39} && pylint tests/unit tests/integration -d all --rcfile=$PYLINTRC",
     "private::lint.renderer": "cd dash/dash-renderer && npm run lint",

requires-dev.txt

@@ -6,7 +6,7 @@ mock==3.0.5;python_version=="2.7"
 flake8==3.8.4
 PyYAML==5.3.1
 pylint==1.9.5;python_version<"3.7"
-pylint==2.6.0;python_version>="3.7"
+pylint==2.9.3;python_version>="3.7"
 astroid==2.4.2;python_version>="3.7"
 black==19.10b0;python_version>="3.0"
 virtualenv==20.2.2;python_version=="2.7"

setup.py

@@ -2,7 +2,7 @@
 from setuptools import setup, find_packages
 
 main_ns = {}
-exec(open("dash/version.py").read(), main_ns)  # pylint: disable=exec-used
+exec(open("dash/version.py").read(), main_ns)  # pylint: disable=exec-used, consider-using-with
 
 
 def read_req_file(req_type):
@@ -23,7 +23,7 @@ def read_req_file(req_type):
         "A Python framework for building reactive web-apps. "
         "Developed by Plotly."
     ),
-    long_description=io.open("README.md", encoding="utf-8").read(),
+    long_description=io.open("README.md", encoding="utf-8").read(),  # pylint: disable=consider-using-with
     long_description_content_type="text/markdown",
     install_requires=read_req_file("install"),
     python_requires=">=2.7, !=3.0.*, !=3.1.*, !=3.2.*",