Git hooks, linting, and other toolchain fixes (#1151)

Author: Marc-Andre-Rivet

Diff for: .circleci/config.yml

@@ -29,7 +29,6 @@ jobs:
     docker:
       - image: circleci/python:3.7-stretch-node-browsers
         environment:
-          PYLINTRC: .pylintrc37
           PYVERSION: python37
 
     steps:
@@ -53,20 +52,13 @@ jobs:
             . venv/bin/activate
             set -eo pipefail
             pip install -e . --progress-bar off && pip list | grep dash
-            flake8 dash setup.py && flake8 --ignore=E123,E126,E501,E722,E731,F401,F841,W503,W504 --exclude=metadata_test.py tests
-            pylint dash setup.py --rcfile=$PYLINTRC
-            pylint tests/unit tests/integration/devtools tests/integration/renderer tests/integration/dash_assets -d all -e C0410,C0411,C0412,C0413,W0109
-            cd dash-renderer && npm ci
-            npm run lint:test && npm run format:test
+            npm install --production && npm run initialize
+            npm run lint
       - run:
-          name: 🐍 Python Unit Tests
+          name: 🐍 Python Unit Tests & ☕ JS Unit Tests
           command: |
             . venv/bin/activate
-            PYTHONPATH=~/dash/tests/assets pytest tests/unit
-      - run:
-          name: ☕ JS Unit Tests
-          command: |
-            cd dash-renderer && npm run test:js
+            npm run test.unit
 
   lint-unit-36:
       <<: *lint-unit
@@ -89,6 +81,7 @@ jobs:
     docker:
       - image: circleci/python:3.7-stretch-node-browsers
         environment:
+          PYLINTRC: .pylintrc37
           PYVERSION: python37
     steps:
       - checkout
@@ -243,7 +236,9 @@ jobs:
       - run:
           name: ️️🏗️  Install packages
           command: |
-            . venv/bin/activate && cd packages && ls -la
+            . venv/bin/activate
+            npm install --production
+            cd packages && ls -la
             find . -name "*.gz" | xargs pip install --no-cache-dir --ignore-installed && cd ..
             sed -i '/dash/d' requires-install.txt
             pip install --no-cache-dir --ignore-installed .
@@ -252,8 +247,7 @@ jobs:
           name: 🧪 Run Integration Tests
           command: |
             . venv/bin/activate
-            TESTFILES=$(circleci tests glob "tests/integration/**/test_*.py" | circleci tests split --split-by=timings)
-            pytest --headless --nopercyfinalize --junitxml=test-reports/junit_intg.xml ${TESTFILES}
+            npm run test.integration
       - store_artifacts:
           path: test-reports
       - store_test_results:

Diff for: .flake8

@@ -0,0 +1,5 @@
+[flake8]
+ignore = C901, E203, E266, E501, E731, W503
+select = B,C,E,F,W,T4
+per-file-ignores =
+    tests/*: E722, F811

Diff for: .huskyrc

@@ -0,0 +1,5 @@
+{
+  "hooks": {
+    "pre-commit": "npm run lint"
+  }
+}

Diff for: .pylintrc

@@ -61,6 +61,7 @@ disable=fixme,
         old-style-class,
         superfluous-parens,
         bad-continuation,
+        line-too-long
 
 
 # Enable the message, report, category or checker with the given id(s). You can
@@ -223,9 +224,6 @@ indent-after-paren=4
 # tab).
 indent-string='    '
 
-# Maximum number of characters on a single line.
-max-line-length=100
-
 # Maximum number of lines in a module
 max-module-lines=1000
 
@@ -468,4 +466,4 @@ known-third-party=enchant
 
 # Exceptions that will emit a warning when being caught. Defaults to
 # "Exception"
-overgeneral-exceptions=Exception
+overgeneral-exceptions=Exception

Diff for: .pylintrc37

@@ -148,7 +148,8 @@ disable=invalid-name,
         possibly-unused-variable,
         too-many-lines,
         too-many-statements,
-        bad-continuation
+        bad-continuation,
+        line-too-long
 
 # Enable the message, report, category or checker with the given id(s). You can
 # either give multiple identifier separated by comma (,) or put this option
@@ -318,9 +319,6 @@ indent-after-paren=4
 # tab).
 indent-string='    '
 
-# Maximum number of characters on a single line.
-max-line-length=100
-
 # Maximum number of lines in a module.
 max-module-lines=1000
 
@@ -567,4 +565,4 @@ known-third-party=enchant
 
 # Exceptions that will emit a warning when being caught. Defaults to
 # "Exception".
-overgeneral-exceptions=Exception
+overgeneral-exceptions=Exception

Diff for: dash-renderer/package-lock.json

@@ -4,18 +4,19 @@
   "description": "render dash components in react",
   "main": "dash_renderer/dash_renderer.min.js",
   "scripts": {
-    "lint": "./node_modules/.bin/eslint --quiet --fix .",
-    "lint:test": "./node_modules/.bin/eslint .",
+    "private::format.js-eslint": "eslint --quiet --fix .",
+    "private::format.js-prettier": "prettier --config .prettierrc --write \"src/**/*.js\"",
+    "private::lint.js-eslint": "eslint .",
+    "private::lint.js-prettier": "prettier --config .prettierrc \"src/**/*.js\" --list-different",
     "build:js": "webpack --build release",
     "build:dev": "webpack --build local",
     "build:local": "renderer build local",
     "build": "renderer build",
     "postbuild": "es-check es5 dash_renderer/*.js",
     "start": "webpack-serve ./webpack.serve.config.js",
-    "format": "prettier --config .prettierrc --write \"src/**/*.js\"",
-    "format:test": "prettier --config .prettierrc \"src/**/*.js\" --list-different",
-    "test": "npm run lint",
-    "test:js": "jest"
+    "test": "jest",
+    "format": "run-s private::format.*",
+    "lint": "run-s private::lint.*"
   },
   "author": "chriddyp",
   "license": "MIT",

Diff for: dash-renderer/package.json

@@ -9,12 +9,12 @@ def has_context(func):
     def assert_context(*args, **kwargs):
         if not flask.has_request_context():
             raise exceptions.MissingCallbackContextException(
-                (
-                    'dash.callback_context.{} '
-                    'is only available from a callback!'
-                ).format(getattr(func, '__name__'))
+                ("dash.callback_context.{} is only available from a callback!").format(
+                    getattr(func, "__name__")
+                )
             )
         return func(*args, **kwargs)
+
     return assert_context
 
 
@@ -23,19 +23,19 @@ class CallbackContext:
     @property
     @has_context
     def inputs(self):
-        return getattr(flask.g, 'input_values', {})
+        return getattr(flask.g, "input_values", {})
 
     @property
     @has_context
     def states(self):
-        return getattr(flask.g, 'state_values', {})
+        return getattr(flask.g, "state_values", {})
 
     @property
     @has_context
     def triggered(self):
-        return getattr(flask.g, 'triggered_inputs', [])
+        return getattr(flask.g, "triggered_inputs", [])
 
     @property
     @has_context
     def response(self):
-        return getattr(flask.g, 'dash_response')
+        return getattr(flask.g, "dash_response")