Skip to content

Commit ba27733

Browse files
committed
fix tests
1 parent 6659085 commit ba27733

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

components/dash-core-components/src/components/Loading.react.js

+9-6
Original file line numberDiff line numberDiff line change
@@ -127,16 +127,19 @@ const Loading = ({
127127

128128
return (
129129
<div
130+
style={{position: 'relative', ...parent_style}}
130131
className={parent_className}
131-
style={
132-
showSpinner
133-
? {position: 'relative', ...parent_style}
134-
: parent_style
135-
}
136132
>
137133
<div
134+
className={parent_className}
138135
style={
139-
showSpinner ? {visibility: 'hidden', ...overlay_style} : {}
136+
showSpinner
137+
? {
138+
visibility: 'hidden',
139+
...overlay_style,
140+
...parent_style,
141+
}
142+
: parent_style
140143
}
141144
>
142145
{children}

components/dash-core-components/tests/integration/loading/test_loading_component.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -406,7 +406,7 @@ def updateDiv(n_clicks):
406406
dash_dcc.find_element(".loading .dash-spinner")
407407
# unlike the default, the content should be visible
408408
dash_dcc.wait_for_text_to_equal("#div-1", "content")
409-
dash_dcc.wait_for_style_to_equal("#root > div", "opacity", "0.5")
409+
dash_dcc.wait_for_style_to_equal("#root > div > div", "opacity", "0.5")
410410

411411
dash_dcc.wait_for_text_to_equal("#div-1", "changed")
412412

0 commit comments

Comments
 (0)