Skip to content

Commit c3d4c89

Browse files
committed
test and changelog entry
1 parent 8e4ca74 commit c3d4c89

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@ This project adheres to [Semantic Versioning](https://semver.org/).
1414
- `custom_spinner` enables using a custom component for loading messages instead of built-in spinners
1515
- `display` overrides the loading status with options for "show," "hide," or "auto"
1616

17+
## Fixed
18+
19+
- [#2362](https://github.com/plotly/dash/pull/2362) Global namespace not polluted any more when loading clientside callbacks.
20+
1721
## [2.16.1] - 2024-03-06
1822

1923
## Fixed

tests/integration/clientside/test_clientside.py

+4
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,10 @@ def update_output(value):
3535
dash_duo.wait_for_text_to_equal("#output-serverside", 'Server says "hello world"')
3636
dash_duo.wait_for_text_to_equal("#output-clientside", 'Client says "hello world"')
3737

38+
assert dash_duo.driver.execute_script("return 'dash_clientside' in window")
39+
assert dash_duo.driver.execute_script("return !('clientside' in window)")
40+
assert dash_duo.driver.execute_script("return !('ns' in window)")
41+
3842

3943
def test_clsd002_chained_serverside_clientside_callbacks(dash_duo):
4044
app = Dash(__name__, assets_folder="assets")

0 commit comments

Comments
 (0)