Merge pull request #1727 from plotly/register-resource-fix

fixed bug causing 'dash_html_components.' to be imported instead of d…

Author: alexcjohnson

dash/dash.py

@@ -618,7 +618,10 @@ def _collect_and_register_resources(self, resources):
         # add the version number of the package as a query parameter
         # for cache busting
         def _relative_url_path(relative_package_path="", namespace=""):
-            if any(x in relative_package_path for x in ["dcc", "html", "dash_table"]):
+            if any(
+                relative_package_path.startswith(x + "/")
+                for x in ["dcc", "html", "dash_table"]
+            ):
                 relative_package_path = relative_package_path.replace("dash.", "")
                 version = importlib.import_module(
                     "{}.{}".format(namespace, os.path.split(relative_package_path)[0])

tests/unit/test_resources.py

@@ -102,3 +102,23 @@ def test_internal(mocker):
     ), "Dynamic resource not available in registered path {}".format(
         app.registered_paths["dash"]
     )
+
+
+def test_collect_and_register_resources(mocker):
+
+    app = dash.Dash(
+        __name__, assets_folder="tests/assets", assets_ignore="load_after.+.js"
+    )
+    with mock.patch("dash.dash.os.stat", return_value=StatMock()):
+        with mock.patch("dash.dash.importlib.import_module") as import_mock:
+            with mock.patch("sys.modules", {"dash_html_components": dcc}):
+                import_mock.return_value = dcc
+                app._collect_and_register_resources(
+                    [
+                        {
+                            "namespace": "dash_html_components",
+                            "relative_package_path": "dash_html_components.min.js",
+                        },
+                    ]
+                )
+                import_mock.assert_any_call("dash_html_components")