Merge branch 'master' into docstring-default-values

Author: Shammamah Hossain

.circleci/config.yml

@@ -1,59 +1,105 @@
 version: 2
 
 jobs:
+
   "python-2.7": &test-template
+    working_directory: ~/dash
     docker:
       - image: circleci/python:2.7-stretch-node-browsers
         environment:
-          REQUIREMENTS_FILE: .circleci/requirements/dev-requirements.txt
           PYLINTRC: .pylintrc
 
     steps:
       - checkout
 
       - run:
-          name: Write deps cache key
-          command: cat "$REQUIREMENTS_FILE" > reqs.txt
+          name: ℹ️ CI Context
+          command: |
+            echo "TRIGGERER: ${CIRCLE_USERNAME}"
+            echo "BUILD_NUMBER: ${CIRCLE_BUILD_NUM}"
+            echo "BUILD_URL: ${CIRCLE_BUILD_URL}"
+            echo "BRANCH: ${CIRCLE_BRANCH}"
+            echo "RUNNING JOB: ${CIRCLE_JOB}"
+            echo "JOB PARALLELISM: ${CIRCLE_NODE_TOTAL}"
+            echo "CIRCLE_REPOSITORY_URL: ${CIRCLE_REPOSITORY_URL}"
+            echo $CIRCLE_JOB > circlejob.txt
 
+      - restore_cache:
+          key: v-{{ checksum "circlejob.txt" }}-{{ checksum "requires-ci.txt" }}-{{ checksum "requires-install.txt" }}
       - run:
-          name: Write job name
-          command: echo $CIRCLE_JOB > circlejob.txt
+          name: 🚧 pip dev requirements
+          command: |
+            sudo pip install --upgrade virtualenv
+            python -m venv venv || virtualenv venv
+            . venv/bin/activate
+            pip install -r requires-install.txt -r requires-ci.txt --quiet
+      - save_cache:
+          key: v-{{ checksum "circlejob.txt" }}-{{ checksum "requires-ci.txt" }}-{{ checksum "requires-install.txt" }}
+          paths:
+              - "venv"
 
       - run:
-          name: Install dependencies
+          name: 🌸 linting
           command: |
-              sudo pip install virtualenv
-              virtualenv venv
-              . venv/bin/activate
-              pip install -r $REQUIREMENTS_FILE --force-reinstall
+            . venv/bin/activate
+            pip install -e .[ci] --quiet
+            pip list | grep dash
+            flake8 dash setup.py
+            flake8 --ignore=E123,E126,E501,E722,E731,F401,F841,W503,W504 --exclude=metadata_test.py tests
+            pylint dash setup.py --rcfile=$PYLINTRC
+            pylint tests/unit tests/integration/devtools tests/integration/renderer tests/integration/dash_assets -d all -e C0410,C0411,C0412,C0413,W0109
+            cd dash-renderer && npm install --ignore-scripts && npm run lint:test && npm run format:test
+
+      - run:
+          name: ⛑ Run unit tests
+          command: |
+            . venv/bin/activate
+            mkdir test-reports
+            PYTHONPATH=~/dash/tests/assets pytest --junitxml=test-reports/junit.xml tests/unit
+      - store_test_results:
+          path: test-reports
+      - store_artifacts:
+          path: test-reports
 
       - run:
-          name: Install dependencies (dash)
+          name: 🚧 build renderer
           command: |
-              git clone [email protected]:plotly/dash-renderer.git
-              git clone [email protected]:plotly/dash-core-components.git
-              git clone [email protected]:plotly/dash-html-components.git
-              git clone [email protected]:plotly/dash-table.git
               . venv/bin/activate
+              cd dash-renderer
+              npm install --ignore-scripts && npm run build:dev && npm run build
               pip install -e . --quiet
-              cd dash-renderer && npm install --ignore-scripts && npm run build && pip install -e . && cd ..
+
+      - run:
+          name: 🚧 install dependencies from latest master commit
+          command: |
+              git clone --depth 1 https://github.com/plotly/dash-core-components.git
+              git clone --depth 1 https://github.com/plotly/dash-html-components.git
+              git clone --depth 1 https://github.com/plotly/dash-table.git
+              git clone --depth 1 https://github.com/plotly/dash-renderer-test-components
+              . venv/bin/activate
               cd dash-core-components && npm install --ignore-scripts && npm run build && pip install -e . && cd ..
               cd dash-html-components && npm install --ignore-scripts && npm run build && pip install -e . && cd ..
               cd dash-table && npm install --ignore-scripts && npm run build && pip install -e . && cd ..
+              cd dash-renderer-test-components && npm install --ignore-scripts && npm run build:all && pip install -e . && cd ..
 
       - run:
-          name: Run tests
+          name: ⚙️ run integration test
           command: |
-              . venv/bin/activate
-              python --version
-              ./test.sh
+            . venv/bin/activate
+            pytest --junitxml=test-reports/junit_intg.xml tests/integration/
+      - store_artifacts:
+          path: test-reports
+      - store_test_results:
+          path: test-reports
+      - store_artifacts:
+          path: /tmp/dash_artifacts
+
 
   "python-3.6":
     <<: *test-template
     docker:
       - image: circleci/python:3.6-stretch-node-browsers
         environment:
-          REQUIREMENTS_FILE: .circleci/requirements/dev-requirements.txt
           PYLINTRC: .pylintrc
           PERCY_ENABLE: 0
 
@@ -62,7 +108,6 @@ jobs:
     docker:
       - image: circleci/python:3.7-stretch-node-browsers
         environment:
-          REQUIREMENTS_FILE: .circleci/requirements/dev-requirements-py37.txt
           PYLINTRC: .pylintrc37
           PERCY_ENABLE: 0
 

.circleci/requirements/dev-requirements-py37.txt

@@ -0,0 +1,16 @@
+# These owners will be the default owners for everything in
+# the repo. Unless a later match takes precedence
+* @alexcjohnson @byronz @Marc-Andre-Rivet 
+
+tests/*  @byronz
+
+*.js     @Marc-Andre-Rivet  @alexcjohnson
+
+_r_*     @rpkyle
+
+*.md     @alexcjohnson
+
+*.py     @alexcjohnson @byronz
+
+
+

.circleci/requirements/dev-requirements.txt

@@ -0,0 +1 @@
+custom: https://plot.ly/products/consulting-and-oem/

.github/CODEOWNERS

@@ -0,0 +1,42 @@
+---
+name: Bug report
+about: Create a report to help us improve
+title: "[BUG]"
+labels: 'Type: Bug'
+assignees: ''
+
+---
+
+Thank you so much for helping improve the quality of Dash!
+
+We do our best to catch bugs during the release process, but we rely on your help to find the ones that slip through.
+
+
+**Describe your context**
+Please provide us your environment so we can easily reproduce the issue.
+
+-  replace the result of `pip list | grep dash` below
+```
+dash                 0.42.0
+dash-core-components 0.47.0
+dash-html-components 0.16.0
+dash-renderer        0.23.0
+dash-table           3.6.0
+```
+-  if frontend related, tell us your Browser, Version and OS
+
+    - OS: [e.g. iOS]
+    - Browser [e.g. chrome, safari]
+    - Version [e.g. 22]
+
+**Describe the bug**
+
+A clear and concise description of what the bug is.
+
+**Expected behavior**
+
+A clear and concise description of what you expected to happen.
+
+**Screenshots**
+
+If applicable, add screenshots or screen recording to help explain your problem.

.github/FUNDING.yml

@@ -0,0 +1,24 @@
+---
+name: Feature request
+about: Suggest an idea for this project
+title: "[Feature Request]"
+labels: 'Type: Enhancement'
+assignees: ''
+
+---
+
+Thanks so much for your interest in Dash!
+
+Before posting an issue here, please check the Dash [community forum](https://community.plot.ly/c/dash) to see if the topic has already been discussed. The community forum is also great for implementation questions. When in doubt, please feel free to just post the issue here :)
+
+**Is your feature request related to a problem? Please describe.**
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+
+**Describe the solution you'd like**
+A clear and concise description of what you want to happen.
+
+**Describe alternatives you've considered**
+A clear and concise description of any alternative solutions or features you've considered.
+
+**Additional context**
+Add any other context or screenshots about the feature request here.

.github/ISSUE_TEMPLATE.md

@@ -0,0 +1,16 @@
+*Start with a description of this PR. Then edit the list below to the items that make sense for your PR scope, and check off the boxes as you go!*
+
+## Contributor Checklist
+
+- [ ] I have broken down my PR scope into the following TODO tasks
+   -  [ ] task 1
+   -  [ ] task 2
+- [ ] I have run the tests locally and they passed. (refer to testing section in [contributing](../CONTRIBUTING.md))
+- [ ] I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR
+
+### optionals
+
+- [ ] I have added entry in the `CHANGELOG.md`
+- [ ] If this PR needs a follow-up in **dash docs**, **community thread**, I have mentioned the relevant URLS as follow
+    -  [ ] this github [#PR number]() updates the dash docs
+    -  [ ] here is the show and tell thread in plotly dash community 

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,23 +1,67 @@
-*.pyc
 *.ipynb_notebooks
 *.ipynb
+
 ignore
-*~
-venv
+*.csv
+*.log
+.DS_Store
+
+# Environments
+.env
+.venv
+env/
+venv/
+ENV/
+env.bak/
+venv.bak/
+
+# IDE
+.idea/*
+.vscode/*
+
+# Byte-compiled / optimized / DLL files
+__pycache__/
+*.py[cod]
+*$py.class
+.mypy_cache/
+
+# Unit test / coverage reports
+htmlcov/
+.tox/
+.nox/
+.coverage
+.coverage.*
+.cache
+nosetests.xml
+coverage.xml
+*.cover
+.hypothesis/
+.pytest_cache/
+
+# Distribution / packaging
+.Python
 build/
+develop-eggs/
 dist/
+downloads/
+eggs/
+.eggs/
 lib/
+lib64/
+parts/
+sdist/
+var/
+wheels/
+pip-wheel-metadata/
+share/python-wheels/
+*.egg-info/
+.installed.cfg
+*.egg
+MANIFEST
 node_modules/
 .npm
-vv/
-venv/
-*.pyc
-*.egg-info
-*.log
-.DS_Store
-dist
-*egg-info*
 npm-debug*
-/.tox
-.idea
-.mypy_cache/
+
+dash_renderer/bundle.js
+dash_renderer/bundle.js.map
+

.github/ISSUE_TEMPLATE/feature_request.md

@@ -59,7 +59,9 @@ disable=fixme,
         invalid-name,
         too-many-lines,
         old-style-class,
-        superfluous-parens
+        superfluous-parens,
+        bad-continuation,
+
 
 # Enable the message, report, category or checker with the given id(s). You can
 # either give multiple identifier separated by comma (,) or put this option
@@ -399,7 +401,7 @@ valid-metaclass-classmethod-first-arg=mcs
 max-args=5
 
 # Maximum number of attributes for a class (see R0902).
-max-attributes=7
+max-attributes=20
 
 # Maximum number of boolean expressions in a if statement
 max-bool-expr=5
@@ -414,7 +416,7 @@ max-locals=15
 max-parents=7
 
 # Maximum number of public methods for a class (see R0904).
-max-public-methods=20
+max-public-methods=40
 
 # Maximum number of return / yield for function / method body
 max-returns=6