Skip to content

Commit eb9c367

Browse files
committed
chore: fix spelling, grammar and fix whitespace
1 parent 15f7c90 commit eb9c367

File tree

9 files changed

+106
-108
lines changed

9 files changed

+106
-108
lines changed

.circleci/config.yml

+92-94
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ jobs:
5555
- save_cache:
5656
key: dep-{{ checksum ".circleci/config.yml" }}-{{ checksum "ver.txt" }}-{{ checksum "requires-dev.txt" }}-{{ checksum "requires-install.txt" }}-{{ checksum "requires-testing.txt" }}
5757
paths:
58-
- venv
58+
- venv
5959
- run:
6060
name: 🌸 Python & JS Lint
6161
command: |
@@ -71,26 +71,26 @@ jobs:
7171
npm run citest.unit
7272
7373
lint-unit-36:
74-
<<: *lint-unit
75-
docker:
76-
- image: circleci/python:3.6.12-stretch-node-browsers
77-
auth:
78-
username: dashautomation
79-
password: $DASH_PAT_DOCKERHUB
80-
environment:
81-
PYLINTRC: .pylintrc
82-
PYVERSION: python36
74+
<<: *lint-unit
75+
docker:
76+
- image: circleci/python:3.6.12-stretch-node-browsers
77+
auth:
78+
username: dashautomation
79+
password: $DASH_PAT_DOCKERHUB
80+
environment:
81+
PYLINTRC: .pylintrc
82+
PYVERSION: python36
8383

8484
lint-unit-27:
85-
<<: *lint-unit
86-
docker:
87-
- image: circleci/python:2.7.18-stretch-node-browsers
88-
auth:
89-
username: dashautomation
90-
password: $DASH_PAT_DOCKERHUB
91-
environment:
92-
PYLINTRC: .pylintrc
93-
PYVERSION: python27
85+
<<: *lint-unit
86+
docker:
87+
- image: circleci/python:2.7.18-stretch-node-browsers
88+
auth:
89+
username: dashautomation
90+
password: $DASH_PAT_DOCKERHUB
91+
environment:
92+
PYLINTRC: .pylintrc
93+
PYVERSION: python27
9494

9595
build-core-37: &build-core
9696
working_directory: ~/dash
@@ -107,7 +107,7 @@ jobs:
107107
- restore_cache:
108108
key: dep-{{ checksum ".circleci/config.yml" }}-{{ checksum "ver.txt" }}-{{ checksum "requires-dev.txt" }}-{{ checksum "requires-install.txt" }}-{{ checksum "requires-testing.txt" }}
109109
- run:
110-
name: ️️🏗️ pip dev requirements
110+
name: 🏗️ pip dev requirements
111111
command: |
112112
sudo pip install --upgrade virtualenv
113113
python -m venv venv || virtualenv venv && . venv/bin/activate
@@ -116,39 +116,39 @@ jobs:
116116
- save_cache:
117117
key: dep-{{ checksum ".circleci/config.yml" }}-{{ checksum "ver.txt" }}-{{ checksum "requires-dev.txt" }}-{{ checksum "requires-install.txt" }}-{{ checksum "requires-testing.txt" }}
118118
paths:
119-
- venv
119+
- venv
120120
- run:
121121
name: ️️🏗️ build core
122122
command: |
123-
. venv/bin/activate && pip install --no-cache-dir --upgrade -e . --progress-bar off && mkdir packages
124-
cd dash-renderer && renderer build && python setup.py sdist && mv dist/* ../packages/ && cd ..
125-
git clone --depth 1 https://github.com/plotly/dash-core-components.git
126-
cd dash-core-components && npm ci && npm run build && python setup.py sdist && mv dist/* ../packages/ && cd ..
127-
ls -la packages
123+
. venv/bin/activate && pip install --no-cache-dir --upgrade -e . --progress-bar off && mkdir packages
124+
cd dash-renderer && renderer build && python setup.py sdist && mv dist/* ../packages/ && cd ..
125+
git clone --depth 1 https://github.com/plotly/dash-core-components.git
126+
cd dash-core-components && npm ci && npm run build && python setup.py sdist && mv dist/* ../packages/ && cd ..
127+
ls -la packages
128128
- persist_to_workspace:
129129
root: ~/dash
130130
paths:
131131
- packages/*.tar.gz
132132

133133
build-core-36:
134-
<<: *build-core
135-
docker:
136-
- image: circleci/python:3.6.12-stretch-node-browsers
137-
auth:
138-
username: dashautomation
139-
password: $DASH_PAT_DOCKERHUB
140-
environment:
141-
PYVERSION: python36
134+
<<: *build-core
135+
docker:
136+
- image: circleci/python:3.6.12-stretch-node-browsers
137+
auth:
138+
username: dashautomation
139+
password: $DASH_PAT_DOCKERHUB
140+
environment:
141+
PYVERSION: python36
142142

143143
build-core-27:
144-
<<: *build-core
145-
docker:
146-
- image: circleci/python:2.7.18-stretch-node-browsers
147-
auth:
148-
username: dashautomation
149-
password: $DASH_PAT_DOCKERHUB
150-
environment:
151-
PYVERSION: python27
144+
<<: *build-core
145+
docker:
146+
- image: circleci/python:2.7.18-stretch-node-browsers
147+
auth:
148+
username: dashautomation
149+
password: $DASH_PAT_DOCKERHUB
150+
environment:
151+
PYVERSION: python27
152152

153153
build-misc-37: &build-misc
154154
working_directory: ~/dash
@@ -174,40 +174,40 @@ jobs:
174174
- save_cache:
175175
key: dep-{{ checksum ".circleci/config.yml" }}-{{ checksum "ver.txt" }}-{{ checksum "requires-dev.txt" }}-{{ checksum "requires-install.txt" }}-{{ checksum "requires-testing.txt" }}
176176
paths:
177-
- venv
177+
- venv
178178
- run:
179179
name: ️️🏗️ build misc
180180
command: |
181-
. venv/bin/activate && pip install --no-cache-dir --upgrade -e . --progress-bar off && mkdir packages
182-
git clone --depth 1 https://github.com/plotly/dash-table.git
183-
cd dash-table && npm ci && npm run build && python setup.py sdist && mv dist/* ../packages/ && cd ..
184-
git clone --depth 1 https://github.com/plotly/dash-html-components.git
185-
cd dash-html-components && npm ci && npm run build && python setup.py sdist && mv dist/* ../packages/ && cd ..
186-
ls -la packages
181+
. venv/bin/activate && pip install --no-cache-dir --upgrade -e . --progress-bar off && mkdir packages
182+
git clone --depth 1 https://github.com/plotly/dash-table.git
183+
cd dash-table && npm ci && npm run build && python setup.py sdist && mv dist/* ../packages/ && cd ..
184+
git clone --depth 1 https://github.com/plotly/dash-html-components.git
185+
cd dash-html-components && npm ci && npm run build && python setup.py sdist && mv dist/* ../packages/ && cd ..
186+
ls -la packages
187187
- persist_to_workspace:
188188
root: ~/dash
189189
paths:
190190
- packages/*.tar.gz
191191

192192
build-misc-36:
193-
<<: *build-misc
194-
docker:
195-
- image: circleci/python:3.6.12-stretch-node-browsers
196-
auth:
197-
username: dashautomation
198-
password: $DASH_PAT_DOCKERHUB
199-
environment:
200-
PYVERSION: python36
193+
<<: *build-misc
194+
docker:
195+
- image: circleci/python:3.6.12-stretch-node-browsers
196+
auth:
197+
username: dashautomation
198+
password: $DASH_PAT_DOCKERHUB
199+
environment:
200+
PYVERSION: python36
201201

202202
build-misc-27:
203-
<<: *build-misc
204-
docker:
205-
- image: circleci/python:2.7.18-stretch-node-browsers
206-
auth:
207-
username: dashautomation
208-
password: $DASH_PAT_DOCKERHUB
209-
environment:
210-
PYVERSION: python27
203+
<<: *build-misc
204+
docker:
205+
- image: circleci/python:2.7.18-stretch-node-browsers
206+
auth:
207+
username: dashautomation
208+
password: $DASH_PAT_DOCKERHUB
209+
environment:
210+
PYVERSION: python27
211211

212212
build-windows-37:
213213
working_directory: ~/dash
@@ -222,10 +222,10 @@ jobs:
222222
- run:
223223
name: ️️🏗️ build core
224224
command: |
225-
pip install --no-cache-dir --upgrade -e .[dev,testing] --progress-bar off
226-
cd dash-renderer && renderer build && python setup.py sdist && mv dist/* ../packages/ && cd ..
227-
git clone --depth 1 https://github.com/plotly/dash-core-components.git
228-
cd dash-core-components && npm ci && npm run build && python setup.py sdist && cd ..
225+
pip install --no-cache-dir --upgrade -e .[dev,testing] --progress-bar off
226+
cd dash-renderer && renderer build && python setup.py sdist && mv dist/* ../packages/ && cd ..
227+
git clone --depth 1 https://github.com/plotly/dash-core-components.git
228+
cd dash-core-components && npm ci && npm run build && python setup.py sdist && cd ..
229229
230230
build-dashr:
231231
working_directory: ~/dashr
@@ -241,9 +241,8 @@ jobs:
241241

242242
steps:
243243
- checkout
244-
245244
- run:
246-
name: ️️🏭 clone and npm build core for R
245+
name: 🏭 clone and npm build core for R
247246
command: |
248247
python -m venv venv
249248
. venv/bin/activate
@@ -259,7 +258,7 @@ jobs:
259258
cd ../dash-table; npm ci && npm run build; rm -rf !(.|..|DESCRIPTION|LICENSE.txt|LICENSE|NAMESPACE|.Rbuildignore|R|man|inst|vignettes|build); cd ..
260259
261260
- run:
262-
name: 🔧fix up dash metadata
261+
name: 🔧 fix up dash metadata
263262
command: |
264263
sudo Rscript dashR/tests/circleci/fixup_metadata.R
265264
@@ -282,7 +281,7 @@ jobs:
282281
>> ${BASH_ENV}
283282
284283
- run:
285-
name: ️️📋 run CRAN package checks
284+
name: 📋 run CRAN package checks
286285
command: |
287286
R CMD build dash-core-components
288287
R CMD build dash-html-components
@@ -313,7 +312,7 @@ jobs:
313312
- run:
314313
name: 🔎 run unit tests
315314
command: |
316-
# unfortunately testthat does not and will not support returning a status
315+
# unfortunately test that does not and will not support returning a status
317316
# code other than success, even when tests fail -- this is a workaround
318317
sudo Rscript -e 'res=devtools::test("dashR/tests/", reporter=default_reporter());df=as.data.frame(res);if(sum(df$failed) > 0 || any(df$error)) {q(status=1)}'
319318
@@ -331,7 +330,6 @@ jobs:
331330
path: test-reports
332331
- store_artifacts:
333332
path: /tmp/dash_artifacts
334-
335333
- run:
336334
name: 🦔 percy finalize
337335
command: npx percy finalize --all
@@ -358,7 +356,7 @@ jobs:
358356
- attach_workspace:
359357
at: ~/dash
360358
- run:
361-
name: ️️🏗️ Install packages
359+
name: ️️🏗️ Install packages
362360
command: |
363361
. venv/bin/activate
364362
npm install --production
@@ -384,26 +382,26 @@ jobs:
384382
when: on_fail
385383

386384
test-36:
387-
<<: *test
388-
docker:
389-
- image: circleci/python:3.6.12-stretch-node-browsers
390-
auth:
391-
username: dashautomation
392-
password: $DASH_PAT_DOCKERHUB
393-
environment:
394-
PERCY_ENABLE: 0
395-
PYVERSION: python36
385+
<<: *test
386+
docker:
387+
- image: circleci/python:3.6.12-stretch-node-browsers
388+
auth:
389+
username: dashautomation
390+
password: $DASH_PAT_DOCKERHUB
391+
environment:
392+
PERCY_ENABLE: 0
393+
PYVERSION: python36
396394

397395
test-27:
398-
<<: *test
399-
docker:
400-
- image: circleci/python:2.7.18-stretch-node-browsers
401-
auth:
402-
username: dashautomation
403-
password: $DASH_PAT_DOCKERHUB
404-
environment:
405-
PERCY_ENABLE: 0
406-
PYVERSION: python27
396+
<<: *test
397+
docker:
398+
- image: circleci/python:2.7.18-stretch-node-browsers
399+
auth:
400+
username: dashautomation
401+
password: $DASH_PAT_DOCKERHUB
402+
environment:
403+
PERCY_ENABLE: 0
404+
PYVERSION: python27
407405

408406
workflows:
409407
version: 2

.github/ISSUE_TEMPLATE/bug_report.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ We do our best to catch bugs during the release process, but we rely on your hel
1313

1414

1515
**Describe your context**
16-
Please provide us your environment so we can easily reproduce the issue.
16+
Please provide us your environment, so we can easily reproduce the issue.
1717

1818
- replace the result of `pip list | grep dash` below
1919
```

.github/pull_request_template.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@
1313
- [ ] I have added entry in the `CHANGELOG.md`
1414
- [ ] If this PR needs a follow-up in **dash docs**, **community thread**, I have mentioned the relevant URLS as follows
1515
- [ ] this GitHub [#PR number]() updates the dash docs
16-
- [ ] here is the show and tell thread in Plotly Dash community
16+
- [ ] here is the show and tell thread in Plotly Dash community

CHANGELOG.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).
55
## UNRELEASED
66

77
### Changed
8-
- [#1531](https://github.com/plotly/dash/pull/1531) Update the format of the docstrings to make them easier to read in the reference pages of Dash Docs and in the console. This also addresses [#1205](https://github.com/plotly/dash/issues/1205)
8+
- [#1531](https://github.com/plotly/dash/pull/1531) Update the format of the docstrings to make them easier to read in the reference pages of Dash Docs and in the console. This also addresses [#1205](https://github.com/plotly/dash/issues/1205)
99
- [#1553](https://github.com/plotly/dash/pull/1553) Increase the z-index of the Dash error menu from 1001 to 1100 in order to make sure it appears above Bootstrap components.
1010

1111
### Fixed
@@ -24,7 +24,7 @@ to close the error messages box.
2424

2525
### Fixed
2626
- [#1530](https://github.com/plotly/dash/pull/1530) Dedent error messages more carefully.
27-
- [#1527](https://github.com/plotly/dash/issues/1527)🐛 `get_asset_url` now pulls from an external source if `assets_external_path` is set.
27+
- [#1527](https://github.com/plotly/dash/issues/1527) 🐛 `get_asset_url` now pulls from an external source if `assets_external_path` is set.
2828
- updated `_add_assets_resource` to build asset urls the same way as `get_asset_url`.
2929
- updated doc string for `assets_external_path` Dash argument to be more clear that it will allways be joined with the `assets_url_path` argument when determining the url to an external asset.
3030
- [#1493](https://github.com/plotly/dash/pull/1493) Fix [#1143](https://github.com/plotly/dash/issues/1143), a bug where having a file with one of several common names (test.py, code.py, org.py, etc) that imports a dash component package would make `import dash` fail with a cryptic error message asking whether you have a file named "dash.py"
@@ -359,7 +359,7 @@ clientside JavaScript callbacks via inline strings.
359359

360360
- [#724](https://github.com/plotly/dash/pull/724), [renderer#175](https://github.com/plotly/dash-renderer/pull/175) Undo/redo toolbar is removed by default, you can enable it with `app=Dash(show_undo_redo=true)`. The CSS hack `._dash-undo-redo:{display:none;}` is no longer needed
361361

362-
- 💥[#709](https://github.com/plotly/dash/pull/709) Merge the `dash-renderer` project into the main dash repo to simplify feature dev workflow. We will keep the [deprecated one](https://github.com/plotly/dash-renderer) for archive purpose.
362+
- 💥 [#709](https://github.com/plotly/dash/pull/709) Merge the `dash-renderer` project into the main dash repo to simplify feature dev workflow. We will keep the [deprecated one](https://github.com/plotly/dash-renderer) for archive purpose.
363363

364364
## [0.43.0] - 2019-05-15
365365
### Changed

CONTRIBUTING.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ $ pip list | grep dash
3232

3333
### Dash-Renderer Beginner Guide
3434

35-
`Dash Renderer` began as a separate repository. It was merged into the main `Dash` repository as part of the 1.0 release. It is the common frontend for all Dash backends (**R** and **Python**), and manages React Component layout and backend event handling.
35+
`Dash Renderer` began as a separate repository. It was merged into the main `Dash` repository as part of the 1.0 release. It is the common frontend for all Dash backends (**R** and **Python**), and manages React Component layout and backend event handling.
3636

3737
If you want to contribute or simply dig deeper into Dash, we encourage you to play and taste it. This is the most efficient way to learn and understand everything under the hood.
3838

dash-renderer/src/components/error/CallbackGraph/CallbackGraphEffects.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export function updateSelectedNode(cy, id) {
3535
node.addClass('selected-node');
3636

3737
// Find the subtree that the node belongs to. A subtree contains
38-
// all all ancestors and descendents that are connected via Inputs
38+
// all all ancestors and descendants that are connected via Inputs
3939
// or Outputs (but not State).
4040

4141
// WARNING: No cycle detection!

dash/renovate.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,17 @@
77
"enabled": true
88
},
99
"pip_requirements": {
10-
"fileMatch": ["requirements.txt", "dev-requirements.txt", "dev-requirements-py37.txt"]
10+
"fileMatch": ["requirements.txt", "dev-requirements.txt", "dev-requirements-py37.txt"]
1111
},
1212
"pip_setup": {
13-
"enabled": true
13+
"enabled": true
1414
},
1515
"packageRules": [{
1616
"packageNames": [
1717
"pylint"
1818
],
1919
"paths": [
20-
"dev-requirements.txt"
20+
"dev-requirements.txt"
2121
],
2222
"allowedVersions": "<2.0.0"
2323
}]

tests/integration/callbacks/test_prevent_update.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ def test_cbpu002_multi_output_no_update(dash_duo):
8787
[Input("btn", "n_clicks")],
8888
)
8989
def show_clicks(n):
90-
# partial or complete cancelation of updates via no_update
90+
# partial or complete cancellation of updates via no_update
9191
return [
9292
no_update if n and n > 4 else n,
9393
no_update if n and n > 2 else n,

0 commit comments

Comments
 (0)