Skip to content

Commit f61767b

Browse files
committed
Server can be True, False, or Flask()
1 parent 17ea03e commit f61767b

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

dash/dash.py

+10-7
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ class Dash(object):
8989
def __init__(
9090
self,
9191
name='__main__',
92-
server=None,
92+
server=True,
9393
static_folder='static',
9494
assets_folder='assets',
9595
assets_url_path='/assets',
@@ -129,14 +129,17 @@ def __init__(
129129
)
130130
self._assets_url_path = assets_url_path
131131

132-
# allow users to supply their own flask server
133-
if server:
134-
if isinstance(server, Flask):
135-
self.server = server
136-
else:
132+
# We have 3 cases: server is either True (we create the server), False (defer server creation) or a Flask app
133+
# instance (we use their server)
134+
if isinstance(server, bool):
135+
if server:
137136
self.server = Flask(name, static_folder=static_folder)
137+
else:
138+
self.server = None
139+
elif isinstance(server, Flask):
140+
self.server = server
138141
else:
139-
self.server = None
142+
raise ValueError('server must be a Flask app, or a boolean')
140143

141144
url_base_pathname, routes_pathname_prefix, requests_pathname_prefix = \
142145
pathname_configs(

0 commit comments

Comments
 (0)