Merge pull request #737 from plotly/dev

Dev

Author: byronz

Diff for: .circleci/config.yml

@@ -12,41 +12,87 @@ jobs:
       - checkout
 
       - run:
-          name: Write deps cache key
-          command: cat "$REQUIREMENTS_FILE" > reqs.txt
+          name: ℹ️ CI Context
+          command: |
+            echo "TRIGGERER: ${CIRCLE_USERNAME}"
+            echo "BUILD_NUMBER: ${CIRCLE_BUILD_NUM}"
+            echo "BUILD_URL: ${CIRCLE_BUILD_URL}"
+            echo "BRANCH: ${CIRCLE_BRANCH}"
+            echo "RUNNING JOB: ${CIRCLE_JOB}"
+            echo "JOB PARALLELISM: ${CIRCLE_NODE_TOTAL}"
+            echo "CIRCLE_REPOSITORY_URL: ${CIRCLE_REPOSITORY_URL}"
+            cat "$REQUIREMENTS_FILE" > reqs.txt
+            echo $CIRCLE_JOB > circlejob.txt
 
+      - restore_cache:
+          key: py-{{ .Branch }}-{{ checksum "circlejob.txt" }}-{{ checksum "reqs.txt" }}-{{ checksum ".circleci/config.yml" }}
       - run:
-          name: Write job name
-          command: echo $CIRCLE_JOB > circlejob.txt
+          name: 🚧 pip dev requirements
+          command: |
+            sudo pip install --upgrade virtualenv
+            python -m venv venv || virtualenv venv
+            . venv/bin/activate
+            pip install -r $REQUIREMENTS_FILE --quiet
+      - save_cache:
+          key: py-{{ .Branch }}-{{ checksum "circlejob.txt" }}-{{ checksum "reqs.txt" }}-{{ checksum ".circleci/config.yml" }}
+          paths:
+              - "venv"
 
       - run:
-          name: Install dependencies
+          name: 🌸 linting
           command: |
-              sudo pip install virtualenv
-              virtualenv venv
-              . venv/bin/activate
-              pip install -r $REQUIREMENTS_FILE --force-reinstall
+            . venv/bin/activate
+            pip install -e . --quiet
+            pip list | grep dash
+            flake8 dash setup.py
+            flake8 --ignore=E123,E126,E501,E722,E731,F401,F841,W503,W504 --exclude=metadata_test.py tests
+            pylint dash setup.py --rcfile=$PYLINTRC
+            pylint tests/unit -d all -e C0410,C0411,C0412,C0413,W0109
+            cd dash-renderer && npm install --ignore-scripts && npm run lint:test && npm run format:test
 
       - run:
-          name: Install dependencies (dash)
+          name: ⛑ Run unit tests
+          command: |
+            . venv/bin/activate
+            mkdir test-reports
+            pytest --junitxml=test-reports/junit.xml tests/unit
+      - store_test_results:
+          path: test-reports
+      - store_artifacts:
+          path: test-reports
+
+      - run:
+          name: 🚧 build renderer
           command: |
-              git clone [email protected]:plotly/dash-renderer.git
-              git clone [email protected]:plotly/dash-core-components.git
-              git clone [email protected]:plotly/dash-html-components.git
-              git clone [email protected]:plotly/dash-table.git
               . venv/bin/activate
+              cd dash-renderer
+              npm install --ignore-scripts && npm run build:dev && npm run build
               pip install -e . --quiet
-              cd dash-renderer && npm install --ignore-scripts && npm run build && pip install -e . && cd ..
+
+      - run:
+          name: 🚧 install dependencies from latest master commit
+          command: |
+              git clone --depth 1 https://github.com/plotly/dash-core-components.git
+              git clone --depth 1 https://github.com/plotly/dash-html-components.git
+              git clone --depth 1 https://github.com/plotly/dash-table.git
+              git clone --depth 1 https://github.com/plotly/dash-renderer-test-components
+              . venv/bin/activate
               cd dash-core-components && npm install --ignore-scripts && npm run build && pip install -e . && cd ..
               cd dash-html-components && npm install --ignore-scripts && npm run build && pip install -e . && cd ..
               cd dash-table && npm install --ignore-scripts && npm run build && pip install -e . && cd ..
+              cd dash-renderer-test-components && npm install --ignore-scripts && npm run build:all && pip install -e . && cd ..
 
       - run:
-          name: Run tests
+          name: ⚙️ run integration test
           command: |
-              . venv/bin/activate
-              python --version
-              ./test.sh
+            . venv/bin/activate
+            pytest --junitxml=test-reports/junit_intg.xml tests/integration/
+
+      - store_test_results:
+          path: test-reports
+      - store_artifacts:
+          path: test-reports
+
 
   "python-3.6":
     <<: *test-template
@@ -73,4 +119,4 @@ workflows:
     jobs:
       - "python-2.7"
       - "python-3.6"
-      - "python-3.7"
+      - "python-3.7"

Diff for: .circleci/requirements/dev-requirements-py37.txt

@@ -11,3 +11,9 @@ requests[security]
 flake8
 pylint==2.3.1
 astroid==2.2.5
+lxml
+requests
+beautifulsoup4
+pytest
+pytest-sugar
+pytest-mock

Diff for: .circleci/requirements/dev-requirements.txt

@@ -10,3 +10,9 @@ plotly==3.7.1
 requests[security]
 flake8
 pylint==1.9.4
+pytest
+pytest-sugar
+pytest-mock
+lxml
+requests
+beautifulsoup4

Diff for: .github/CODEOWNERS

@@ -0,0 +1,16 @@
+# These owners will be the default owners for everything in
+# the repo. Unless a later match takes precedence
+* @alexcjohnson @byronz @Marc-Andre-Rivet 
+
+tests/*  @byronz
+
+*.js     @Marc-Andre-Rivet  @alexcjohnson
+
+_r_*     @rpkyle
+
+*.md     @alexcjohnson @chriddyp
+
+*.py     @alexcjohnson @byronz
+
+
+

Diff for: .gitignore

@@ -1,23 +1,67 @@
-*.pyc
 *.ipynb_notebooks
 *.ipynb
+
 ignore
-*~
-venv
+*.csv
+*.log
+.DS_Store
+
+# Environments
+.env
+.venv
+env/
+venv/
+ENV/
+env.bak/
+venv.bak/
+
+# IDE
+.idea/*
+.vscode/*
+
+# Byte-compiled / optimized / DLL files
+__pycache__/
+*.py[cod]
+*$py.class
+.mypy_cache/
+
+# Unit test / coverage reports
+htmlcov/
+.tox/
+.nox/
+.coverage
+.coverage.*
+.cache
+nosetests.xml
+coverage.xml
+*.cover
+.hypothesis/
+.pytest_cache/
+
+# Distribution / packaging
+.Python
 build/
+develop-eggs/
 dist/
+downloads/
+eggs/
+.eggs/
 lib/
+lib64/
+parts/
+sdist/
+var/
+wheels/
+pip-wheel-metadata/
+share/python-wheels/
+*.egg-info/
+.installed.cfg
+*.egg
+MANIFEST
 node_modules/
 .npm
-vv/
-venv/
-*.pyc
-*.egg-info
-*.log
-.DS_Store
-dist
-*egg-info*
 npm-debug*
-/.tox
-.idea
-.mypy_cache/
+
+dash_renderer/bundle.js
+dash_renderer/bundle.js.map
+

Diff for: .vscode/settings.json

@@ -0,0 +1,6 @@
+{
+    "python.linting.flake8Enabled": false,
+    "python.linting.enabled": true,
+    "python.linting.pylintEnabled": true,
+    "python.pythonPath": "/Users/byron/code/.venv/dev/bin/python"
+}