Skip to content

Review dcc.Graph and move suitable tests to dcc repo #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Marc-Andre-Rivet opened this issue Nov 26, 2019 · 0 comments
Open

Review dcc.Graph and move suitable tests to dcc repo #1031

Marc-Andre-Rivet opened this issue Nov 26, 2019 · 0 comments
Assignees
Labels
bug something broken P3 backlog regression this used to work
Milestone

Comments

@Marc-Andre-Rivet
Copy link
Contributor

Updating from plotly.js 1.51.1 to 1.51.2 caused https://github.com/plotly/dash/blob/dev/tests/integration/test_render.py#L974 to fail obscurely in the Dash repo.

  • Review tests involving dcc.Graph: those that are not clearly testing a Dash/renderer behavior should be moved to dcc
  • Review test content to make tests more resilient (e.g. in the example above we care about only some of the props, not all of them, nor the entire event structure -- that's for Plotly.js to test)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken P3 backlog regression this used to work
Projects
None yet
Development

No branches or pull requests

2 participants