Skip to content

Defer pytest import? #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chriddyp opened this issue Jul 3, 2019 · 1 comment · Fixed by #808
Closed

Defer pytest import? #804

chriddyp opened this issue Jul 3, 2019 · 1 comment · Fixed by #808
Assignees

Comments

@chriddyp
Copy link
Member

chriddyp commented Jul 3, 2019

Looks like pytest isn't the safest dependency, causing issues with scikit-learn: https://community.plot.ly/t/pytest-transient-dependency/25383

Could we move the import pytest into the testing module/class/function itself and not require it upon install? We could even have a separate install with setup.py's "extras" feature (https://setuptools.readthedocs.io/en/latest/setuptools.html#declaring-extras-optional-features-with-their-own-dependencies) like pip install dash[testing] or something.

@byronz
Copy link
Contributor

byronz commented Jul 3, 2019

@chriddyp in 1.0, we already use the extras feature in setup.py, so the pip install dash[testing] might be the way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants