From 3eac50a0e07dbad395c5d56149126a0e941a8cb0 Mon Sep 17 00:00:00 2001 From: Antoine Roy-Gobeil Date: Fri, 24 Sep 2021 17:42:39 -0400 Subject: [PATCH 1/4] dash-table: Run demo page off React's dev bundles --- components/dash-table/demo/index.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/components/dash-table/demo/index.html b/components/dash-table/demo/index.html index 7884111a5c..480e65a4b5 100644 --- a/components/dash-table/demo/index.html +++ b/components/dash-table/demo/index.html @@ -5,8 +5,8 @@
- - + + From a25cca92254c34ff82cafe38d9e591703f465cda Mon Sep 17 00:00:00 2001 From: Antoine Roy-Gobeil Date: Fri, 24 Sep 2021 17:43:22 -0400 Subject: [PATCH 2/4] dash-table: Add missing key prop on column headers --- components/dash-table/src/dash-table/derived/header/content.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/dash-table/src/dash-table/derived/header/content.tsx b/components/dash-table/src/dash-table/derived/header/content.tsx index 629b44512e..7953c71b7e 100644 --- a/components/dash-table/src/dash-table/derived/header/content.tsx +++ b/components/dash-table/src/dash-table/derived/header/content.tsx @@ -283,7 +283,7 @@ function getter( ); return ( -
+
{!column_selectable || !selectable ? null : ( Date: Wed, 29 Sep 2021 18:07:27 -0400 Subject: [PATCH 3/4] dash-table: asserts that no warnings are emitted --- .../dash-table/tests/selenium/test_header.py | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/components/dash-table/tests/selenium/test_header.py b/components/dash-table/tests/selenium/test_header.py index f6ca3b665c..ca6ccd1291 100644 --- a/components/dash-table/tests/selenium/test_header.py +++ b/components/dash-table/tests/selenium/test_header.py @@ -127,3 +127,18 @@ def test_head004_change_single_row_header(test): assert target.column("rows").get_text(0) == "Chill" assert test.get_log_errors() == [] + + +def test_head005_no_warnings_emitted(test): + test.start_server( + get_app(dict(merge_duplicate_headers=True)), + debug=True, + use_reloader=False, + use_debugger=True, + dev_tools_hot_reload=False, + ) + + target = test.table("table") + + wait.until(lambda: target.column(6).get().get_attribute("colspan") == "4", 3) + assert test.get_logs() == [] From b1fa988fbf5961e3728839bcaa5aa124bbd5a71f Mon Sep 17 00:00:00 2001 From: Antoine Roy-Gobeil Date: Wed, 29 Sep 2021 22:46:33 -0400 Subject: [PATCH 4/4] changelog for #1778 --- components/dash-table/CHANGELOG.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/components/dash-table/CHANGELOG.md b/components/dash-table/CHANGELOG.md index 89549d8f42..92badbc054 100644 --- a/components/dash-table/CHANGELOG.md +++ b/components/dash-table/CHANGELOG.md @@ -2,6 +2,11 @@ All notable changes to this project will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org/). +## [Unreleased] +### Fixed +- [#1778](https://github.com/plotly/dash/pull/1778) Fix React warnings stating + that each child in a list should have a unique "key" prop + ## [4.12.0] - 2021-07-09 ### Fixed - [#907](https://github.com/plotly/dash-table/pull/907)