From f6a5dd715cdce8a31558574fa98b49639179772d Mon Sep 17 00:00:00 2001 From: philippe Date: Mon, 18 Jul 2022 10:51:30 -0400 Subject: [PATCH 1/3] Add no-console eslint rule to renderer. --- dash/dash-renderer/.eslintrc.js | 1 + 1 file changed, 1 insertion(+) diff --git a/dash/dash-renderer/.eslintrc.js b/dash/dash-renderer/.eslintrc.js index 93dc6fee59..9165dbaea4 100644 --- a/dash/dash-renderer/.eslintrc.js +++ b/dash/dash-renderer/.eslintrc.js @@ -28,6 +28,7 @@ module.exports = { 'prefer-arrow-callback': 2, 'quote-props': [2, 'as-needed'], 'quotes': [2, 'single', { 'avoidEscape': true }], + 'no-console': 2, '@typescript-eslint/ban-types': 0, '@typescript-eslint/explicit-module-boundary-types': 0, '@typescript-eslint/array-type': 0, From c1737c0cc49991399e3cabd51dbfb9c31d23e282 Mon Sep 17 00:00:00 2001 From: philippe Date: Mon, 18 Jul 2022 10:52:25 -0400 Subject: [PATCH 2/3] Fix no console. --- dash/dash-renderer/src/actions/api.js | 1 + dash/dash-renderer/src/actions/callbacks.ts | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/dash/dash-renderer/src/actions/api.js b/dash/dash-renderer/src/actions/api.js index a2d9d5073a..aada02d5d4 100644 --- a/dash/dash-renderer/src/actions/api.js +++ b/dash/dash-renderer/src/actions/api.js @@ -60,6 +60,7 @@ export default function apiThunk(endpoint, method, store, id, body) { // fetch rejection - this means the request didn't return, // we don't get here from 400/500 errors, only network // errors or unresponsive servers. + // eslint-disable-next-line no-console console.log('fetch error', res); setConnectionStatus(false); return; diff --git a/dash/dash-renderer/src/actions/callbacks.ts b/dash/dash-renderer/src/actions/callbacks.ts index 4764bdfb6c..63f4f7b633 100644 --- a/dash/dash-renderer/src/actions/callbacks.ts +++ b/dash/dash-renderer/src/actions/callbacks.ts @@ -650,7 +650,6 @@ export function executeCallback( let lastError: any; const additionalArgs: [string, string, boolean?][] = []; - console.log(cb.callback.output, getState().callbackJobs); values(getState().callbackJobs).forEach( (job: CallbackJobPayload) => { if (cb.callback.output === job.output) { From 7a0feb0d280e85fdd5fd3b82659421d9ed5cd063 Mon Sep 17 00:00:00 2001 From: philippe Date: Wed, 20 Jul 2022 13:46:10 -0400 Subject: [PATCH 3/3] Update changelog. --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 77abe9df08..dddf134358 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,10 @@ All notable changes to `dash` will be documented in this file. This project adheres to [Semantic Versioning](https://semver.org/). +## [UNRELEASED] + +- [#2146](https://github.com/plotly/dash/pull/2146) Remove leftover debug console.log statement. + ## [2.6.0] - 2022-07-14 ### Added