From 8b64280c97a4f1b4ccf35f44cae98b86e7a645ce Mon Sep 17 00:00:00 2001 From: Philippe Duval Date: Wed, 31 Oct 2018 14:04:41 -0400 Subject: [PATCH 1/2] Change registered_paths to a `collections.defaultdict(set)`. --- dash/dash.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/dash/dash.py b/dash/dash.py index 0a68d70bce..2311571eab 100644 --- a/dash/dash.py +++ b/dash/dash.py @@ -167,7 +167,7 @@ def _handle_error(error): self.assets_ignore = assets_ignore - self.registered_paths = {} + self.registered_paths = collections.defaultdict(set) # urls self.routes = [] @@ -313,10 +313,7 @@ def _collect_and_register_resources(self, resources): def _relative_url_path(relative_package_path='', namespace=''): # track the registered packages - if namespace in self.registered_paths: - self.registered_paths[namespace].append(relative_package_path) - else: - self.registered_paths[namespace] = [relative_package_path] + self.registered_paths[namespace].add(relative_package_path) module_path = os.path.join( os.path.dirname(sys.modules[namespace].__file__), From 229978b91a1bc3447508999ae027449e5c1beef5 Mon Sep 17 00:00:00 2001 From: Philippe Duval Date: Mon, 5 Nov 2018 10:06:29 -0500 Subject: [PATCH 2/2] Update version and changelog. --- CHANGELOG.md | 4 ++++ dash/version.py | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 82e52d44d3..75d4c36f01 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.28.6 - 2018-11-05 +## Fixed +- `Dash.registered_paths` changed to a `collections.defaultdict(set)`, was appending the same package paths on every index. [#443](https://github.com/plotly/dash/pull/443) + ## 0.28.5 - 2018-10-18 ## Fixed - Replace windows endline when generating the components classes docstring [#431](https://github.com/plotly/dash/pull/431) diff --git a/dash/version.py b/dash/version.py index 1364a70d22..b0897f0bfd 100644 --- a/dash/version.py +++ b/dash/version.py @@ -1 +1 @@ -__version__ = '0.28.5' +__version__ = '0.28.6'