|
46 | 46 | #' constructing their own authorization front-end or otherwise need to know
|
47 | 47 | #' where the application is making API calls.
|
48 | 48 | #' }
|
49 |
| -#' \item{`exclude_plotly_bundle`}{ |
50 |
| -#' Whether or not to exclude the plotly.js bundle when "core components" exist, |
51 |
| -#' but [dashCoreComponents::coreGraph] is not provided to the `layout_set()` |
52 |
| -#' method (i.e., the initial layout). |
53 |
| -#' The only time `exclude_plotly_bundle` should be `TRUE` is if you don't want |
54 |
| -#' a `coreGraph()` in the initial layout, but want to insert one via a callback. |
55 |
| -#' } |
56 | 49 | #' }
|
57 | 50 | #'
|
58 | 51 | #' @section Methods:
|
@@ -121,8 +114,7 @@ Dash <- R6::R6Class(
|
121 | 114 | serve_locally = TRUE,
|
122 | 115 | routes_pathname_prefix = '/',
|
123 | 116 | requests_pathname_prefix = '/',
|
124 |
| - suppress_callback_exceptions = FALSE, |
125 |
| - exclude_plotly_bundle = TRUE) { |
| 117 | + suppress_callback_exceptions = FALSE) { |
126 | 118 |
|
127 | 119 | # argument type checking
|
128 | 120 | assertthat::assert_that(is.character(name))
|
@@ -530,18 +522,6 @@ Dash <- R6::R6Class(
|
530 | 522 |
|
531 | 523 | deps_layout <- unlist(deps_layout, recursive=FALSE)
|
532 | 524 |
|
533 |
| - # if core components are used, but no coreGraph() exists, |
534 |
| - # don't include the plotly.js bundle |
535 |
| - if (private$exclude_plotly_bundle) { |
536 |
| - hasCore <- "dashCoreComponents" %in% pkgs |
537 |
| - hasGraph <- component_contains_type(layout, "dashCoreComponents", "Graph") |
538 |
| - if (hasCore && !hasGraph) { |
539 |
| - idx <- which(pkgs %in% "dashCoreComponents") |
540 |
| - scripts <- deps_layout[[idx]][["script"]] |
541 |
| - deps_layout[[idx]][["script"]] <- scripts[!grepl("^plotly-*", scripts)] |
542 |
| - } |
543 |
| - } |
544 |
| - |
545 | 525 | # add on HTML dependencies we've identified by crawling the layout
|
546 | 526 | private$dependencies <- c(private$dependencies, deps_layout)
|
547 | 527 |
|
|
0 commit comments