Skip to content

change pruned_errors to dev_tools_prune_errors #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexcjohnson opened this issue Aug 11, 2019 · 2 comments
Closed

change pruned_errors to dev_tools_prune_errors #112

alexcjohnson opened this issue Aug 11, 2019 · 2 comments
Assignees
@rpkyle

Comments

@alexcjohnson
Copy link
Collaborator

in plotly/dash#860 I implemented a similar feature to pruned_errors on the Python side. But for consistency I prefixed it dev_tools_, and I find it clearer as a verb "prune" rather than an adjective "pruned." Can we change the R version to match?
@rpkyle
Copy link
Contributor

rpkyle commented Aug 11, 2019

in plotly/dash#860 I implemented a similar feature to pruned_errors on the Python side. But for consistency I prefixed it dev_tools_, and I find it clearer as a verb "prune" rather than an adjective "pruned." Can we change the R version to match?

For sure, I can open a PR to close this issue tomorrow.

@rpkyle rpkyle self-assigned this Aug 11, 2019
@rpkyle rpkyle mentioned this issue Aug 12, 2019
Merged
@rpkyle
Copy link
Contributor

rpkyle commented Sep 3, 2019

Closed by #113.

@rpkyle rpkyle closed this as completed Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rpkyle rpkyle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcjohnson @Marc-Andre-Rivet @rpkyle