Skip to content

Commit 6d7ddad

Browse files
committed
documentation changes for R CMD check
1 parent dd9a3fa commit 6d7ddad

File tree

5 files changed

+20
-2
lines changed

5 files changed

+20
-2
lines changed

R/print.R

+1
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ knit_print.plotly_hash <- function(x, options, ...) {
2929
#' Print a 'built' plotly object in a knitr doc
3030
#'
3131
#' @param x a plotly object
32+
#' @param options knitr options.
3233
#' @param ... additional arguments
3334
#' @export
3435
knit_print.plotly_built <- knit_print.plotly_hash

man/ggplotly.Rd

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/knit_print.plotly_built.Rd

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vignettes/intro.Rmd

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
---
22
title: "An overview of plotly's R API"
33
author: "Carson Sievert"
4-
output: rmarkdown::html_vignette
4+
output:
5+
rmarkdown::html_vignette:
6+
self_contained: false
57
vignette: >
68
%\VignetteEngine{knitr::rmarkdown}
79
%\VignetteIndexEntry{Plotly DSL}

vignettes/subplot.Rmd

+12-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ author: "Carson Sievert"
44
output:
55
rmarkdown::html_vignette:
66
toc: true
7-
standalone: false
7+
self_contained: false
88
vignette: >
99
%\VignetteEngine{knitr::rmarkdown}
1010
%\VignetteIndexEntry{subplot}
@@ -17,6 +17,17 @@ knitr::opts_chunk$set(
1717
comment = "#>",
1818
fig.width = 7
1919
)
20+
# someday we may want to do pngs to reduce size...
21+
# printly <- function(p, options, ...) {
22+
# p <- layout(p, height = options$fig.height, width = options$fig.width)
23+
# u <- plotly::plotly_POST(p, filename = Sys.time())$url
24+
# sprintf(
25+
# "<a href='%s'> <img src='%s.png' style='%s' /> </a>",
26+
# u, u, "max-width:100%"
27+
# )
28+
# }
29+
# assignInNamespace("knit_print.plotly_hash", printly, asNamespace("plotly"))
30+
# assignInNamespace("knit_print.plotly_built", printly, asNamespace("plotly"))
2031
```
2132

2233
## Introduction

0 commit comments

Comments
 (0)